From e610a2b491fb354adcedb3ad683ca631a1efc011 Mon Sep 17 00:00:00 2001 From: BoykoAlex Date: Mon, 27 Jul 2026 20:12:18 -0700 Subject: [PATCH 1/2] Adopt LSPHoverRegion introduction Signed-off-by: BoykoAlex --- .../src/org/eclipse/lsp4e/jdt/LSJavaHoverProvider.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/org.eclipse.lsp4e.jdt/src/org/eclipse/lsp4e/jdt/LSJavaHoverProvider.java b/org.eclipse.lsp4e.jdt/src/org/eclipse/lsp4e/jdt/LSJavaHoverProvider.java index 0099c2dae..5b5790675 100644 --- a/org.eclipse.lsp4e.jdt/src/org/eclipse/lsp4e/jdt/LSJavaHoverProvider.java +++ b/org.eclipse.lsp4e.jdt/src/org/eclipse/lsp4e/jdt/LSJavaHoverProvider.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2017, 2020 Pivotal Inc. and others. + * Copyright (c) 2017, 2026 Pivotal Inc. and others. * This program and the accompanying materials are made * available under the terms of the Eclipse Public License 2.0 * which is available at https://www.eclipse.org/legal/epl-2.0/ @@ -47,7 +47,8 @@ public class LSJavaHoverProvider extends JavadocHover { if (textViewer == null || hoverRegion == null) { return null; } - CompletableFuture<@Nullable String> lsHoverFuture = this.lsBasedHover.getHoverInfoFuture(textViewer, hoverRegion); + IRegion lsHoverRegion = getHoverRegion(textViewer, hoverRegion.getOffset()); + CompletableFuture<@Nullable String> lsHoverFuture = this.lsBasedHover.getHoverInfoFuture(textViewer, lsHoverRegion == null ? hoverRegion : lsHoverRegion); final var lsHtmlHoverContent = new AtomicReference<@Nullable String>(); final var jdtHoverControlInput = new AtomicReference<@Nullable JavadocBrowserInformationControlInput>(); From 3d65ba74646825f991ca1a59955251ac727626c9 Mon Sep 17 00:00:00 2001 From: BoykoAlex Date: Mon, 27 Jul 2026 21:41:19 -0700 Subject: [PATCH 2/2] Bump up bundle version Signed-off-by: BoykoAlex --- org.eclipse.lsp4e.jdt/META-INF/MANIFEST.MF | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.lsp4e.jdt/META-INF/MANIFEST.MF b/org.eclipse.lsp4e.jdt/META-INF/MANIFEST.MF index a94a672c8..7b2ae0f74 100644 --- a/org.eclipse.lsp4e.jdt/META-INF/MANIFEST.MF +++ b/org.eclipse.lsp4e.jdt/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: JDT Integration for LSP4E Bundle-SymbolicName: org.eclipse.lsp4e.jdt;singleton:=true -Bundle-Version: 0.14.2.qualifier +Bundle-Version: 0.14.3.qualifier Export-Package: org.eclipse.lsp4e.jdt Automatic-Module-Name: org.eclipse.lsp4e.jdt Bundle-Activator: org.eclipse.lsp4e.jdt.LanguageServerJdtPlugin