cl--assertion-failed on Emacs 27.0.50

[SuJiKiNen]

I use git build,I see these failures on espuds itself's test,the Readme has a similar situation on Emacs 25.x,
should I need to downgrade to a specific version of Emacs?

I try various ways
cask exec ert-runner --script
cask exec ert-runner --win this one make Emacs hanging on test 27
cask exec ert-runner --no-win same as before

Test then-current-point-should-be-in-bold-when-not-bold backtrace:
  cl--assertion-failed((espuds-character-bold-p) "Expected current poi
  (or (espuds-character-bold-p) (cl--assertion-failed '(espuds-charact
  (progn (or (espuds-character-bold-p) (cl--assertion-failed '(espuds-
  (lambda nil (progn (or (espuds-character-bold-p) (cl--assertion-fail
  apply((lambda nil (progn (or (espuds-character-bold-p) (cl--assertio
  (let ((matches) (matching (catch 'break (mapc (function (lambda (ste
  espuds-call-step("current point should be in bold" nil)
  (if (functionp arg) (espuds-define-step name arg) (espuds-call-step 
  (let ((arg (car args))) (if (functionp arg) (espuds-define-step name
  Then("current point should be in bold")
  (lambda nil (lisp-mode) (set-face-attribute font-lock-keyword-face n
  mock-protect((lambda nil (lisp-mode) (set-face-attribute font-lock-k
  (let ((buffer-name "*espuds*")) (if (get-buffer buffer-name) (kill-b
  (lambda nil (let ((buffer-name "*espuds*")) (if (get-buffer buffer-n
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name then-current-point-should-be-in-bold-
  ert-run-or-rerun-test(#s(ert--stats :selector (and t) :tests [#s(ert
  ert-run-tests((and t) (lambda (event-type &rest event-args) (cond ((
  ert-runner/run-tests-batch((and t))
  (let ((stats (ert-runner/run-tests-batch selector))) (kill-emacs (if
  ert-runner/run-tests-batch-and-exit((and t))
  (if ert-runner-verbose (ert-runner/run-tests-batch-and-exit ert-runn
  (let ((test-files (ert-runner--test-files tests)) (test-helper (f-ex
  ert-runner/run()
  apply(ert-runner/run nil)
  commander--handle-command(nil)
  commander-parse(("--debug" "--script"))

[davidshepherd7]

Try changing this: https://github.com/ecukes/espuds/blob/master/test/test-helper.el#L33 to include emacs 27 (I thought there was a fix for this in emacs by now, but maybe it didn't work 😞 ).

[SuJiKiNen]

run
cask exec ert-runner --win

cask exec ert-runner --no-win
got nothing

cask exec ert-runner got one failed output

Test when-i-delete-other-windows condition:

    (error "Window #<window 1 on *espuds*> too small for splitting")

does it mean ok?

[davidshepherd7]

Try using `make test` instead, that will set the correct flags (I'm not sure what they are).

…

On Mon, 9 Apr 2018, 01:48 SuJiKiNen, ***@***.***> wrote: run cask exec ert-runner --win cask exec ert-runner --no-win got nothing cask exec ert-runner got one failed output Test when-i-delete-other-windows condition: (error "Window #<window 1 on *espuds*> too small for splitting") does it mean ok? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAwk1FRMW_H_Yh5wGImM1WmY2INhMxjnks5tmq_tgaJpZM4TLU9z> .

[SuJiKiNen]

does the successful running given information about how many tests passed?
I haven't seen a successful output of make test before, and I go same as
cask exec ert-runner --no-win result I said before
I trace from Cask here,due to unit test I've written passed from obviously fail case.
>_<

[davidshepherd7]

Here's what a successful run of the tests looks like on Travis: https://travis-ci.org/ecukes/espuds/jobs/300579889

So unfortunately no, it looks like when ert runs with a gui it doesn't print the number of successes. It if it exits with a successful status then presumably everything has passed. You can check this with e.g. echo $? immediately after running the tests, 0 is success.

I trace from Cask here,due to unit test I've written passed from obviously fail case.

That sounds like this issue again 😞

The fix is to basically do this again for emacs 27. I suppose someone should go and pester again emacs-devel to get upstream fixed, I thought it already had been.

[SuJiKiNen]

now I can make sure that adding version to that line,Fixed it.
It drive me crazy last few days,I have no too much experience and knowledge on debugging this.
Thank you very much,have a nice day!!

btw:
the window failed case,it must come from Emacs newer version ,It throw a warning or something to avoid splitting too small window.