Skip to content

Version inconsistency #12

@remicollet

Description

@remicollet

Using 1.0.0dev from pecl

1/ usually "dev" are not published on pecl

rather alpha1, beta1, RC1, RC2...
"dev", is usually for git sources (no number)
and you canhave multiple alpha/beta/RC releases

2/ No tag ?

I only see 0.5.2, 3 weeks old

3/ Extension version is 1.0

See https://github.com/eklausme/php-md4c/blob/0.5.2/md4c.c#L9992

4/ Extension report as 1.1 / 0.5.2

See https://github.com/eklausme/php-md4c/blob/0.5.2/md4c.c#L9953

As I understand 1.1 is the extension and 0.5.2 the library

5/ Common practice

Define PHP_MD4C_VERSION macro in php-md4c.h, and use it everywhere (zend_module_entry and MINFO)

Other benefit: its value will be checked when uploaded on pecl

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions