Skip to content

Commit e15a3c2

Browse files
committed
Add incompatible yaml tests to skip list (#374)
1 parent 5f8a17a commit e15a3c2

File tree

1 file changed

+34
-18
lines changed
  • internal/build/cmd/generate/commands/gentests

1 file changed

+34
-18
lines changed

internal/build/cmd/generate/commands/gentests/skips.go

Lines changed: 34 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,38 +19,38 @@ package gentests
1919

2020
import (
2121
"fmt"
22-
"strings"
22+
"strings"
2323

24-
"gopkg.in/yaml.v2"
24+
"gopkg.in/yaml.v2"
2525
)
2626

2727
var skipTests map[string][]string
2828

2929
func init() {
30-
err := yaml.NewDecoder(strings.NewReader(skipTestsYAML)).Decode(&skipTests)
31-
if err != nil {
32-
panic(fmt.Sprintf("ERROR: %v", err))
33-
}
30+
err := yaml.NewDecoder(strings.NewReader(skipTestsYAML)).Decode(&skipTests)
31+
if err != nil {
32+
panic(fmt.Sprintf("ERROR: %v", err))
33+
}
3434
}
3535

3636
var skipFiles = []string{
37-
"update/85_fields_meta.yml", // Uses non-existing API property
38-
"update/86_fields_meta_with_types.yml", // --||--
37+
"update/85_fields_meta.yml", // Uses non-existing API property
38+
"update/86_fields_meta_with_types.yml", // --||--
3939

40-
"ml/jobs_get_result_buckets.yml", // Passes string value to int variable
41-
"ml/jobs_get_result_categories.yml", // --||--
42-
"ml/set_upgrade_mode.yml", // --||--
40+
"ml/jobs_get_result_buckets.yml", // Passes string value to int variable
41+
"ml/jobs_get_result_categories.yml", // --||--
42+
"ml/set_upgrade_mode.yml", // --||--
4343

44-
"ml/evaluate_data_frame.yml", // Floats as map keys
44+
"ml/evaluate_data_frame.yml", // Floats as map keys
4545

46-
"search/320_disallow_queries.yml", // Tries to match key in an empty map (`transient:{}`)
46+
"search/320_disallow_queries.yml", // Tries to match key in an empty map (`transient:{}`)
4747

48-
"watcher/stats/10_basic.yml", // Sets "emit_stacktraces" as string ("true"), not bool
48+
"watcher/stats/10_basic.yml", // Sets "emit_stacktraces" as string ("true"), not bool
4949

50-
"search.highlight/20_fvh.yml", // bad backslash
50+
"search.highlight/20_fvh.yml", // bad backslash
5151

52-
"indices.stats/50_disk_usage.yml", // Needs a replacement mechanism implementation
53-
"indices.stats/60_field_usage.yml", // Needs a replacement mechanism implementation
52+
"indices.stats/50_disk_usage.yml", // Needs a replacement mechanism implementation
53+
"indices.stats/60_field_usage.yml", // Needs a replacement mechanism implementation
5454
}
5555

5656
// TODO: Comments into descriptions for `Skip()`
@@ -152,6 +152,15 @@ search/issue9606.yml:
152152
bulk/80_cas.yml:
153153
bulk/81_cas_with_types.yml:
154154
155+
# Incompatible to date with test runner
156+
tsdb/80_index_resize.yml:
157+
- shrink
158+
- clone
159+
160+
# Number conversion needs to be addressed in test gen
161+
tsdb/40_search.yml:
162+
- aggregate a metric
163+
155164
# ----- X-Pack ----------------------------------------------------------------
156165
157166
# Float "3.0" decoded as "3" by gopkg.in/yaml.v2
@@ -354,4 +363,11 @@ searchable_snapshots/10_usage.yml:
354363
# Expects count 2 but returns only 1
355364
service_accounts/10_basic.yml:
356365
- Test service account tokens
357-
`
366+
367+
# Replace stash token in payload not yet implemented
368+
api_key/20_query.yml:
369+
- Test query api key
370+
371+
change_password/10_basic.yml:
372+
- Test changing users password with prehashed password
373+
`

0 commit comments

Comments
 (0)