fix stream mapping

- collect response into binary before mapping
- don't try to map error responses

Author: magnetised

lib/phoenix/sync/electric.ex

@@ -600,7 +600,7 @@ defmodule Phoenix.Sync.Electric do
   def map_response_body(body, mapper) when is_binary(body) and is_function(mapper, 1) do
     body
     |> @json.decode!()
-    |> Phoenix.Sync.Electric.map_response_body(mapper)
+    |> map_response_body(mapper)
     |> then(fn item -> [@json.encode_to_iodata!(item)] end)
   end
 

lib/phoenix/sync/electric/api_adapter.ex

@@ -55,11 +55,10 @@ if Code.ensure_loaded?(Electric.Shapes.Api) do
       end
 
       defp apply_transform(stream, transform_fun) do
-        Stream.flat_map(stream, fn chunk ->
-          chunk
-          |> IO.iodata_to_binary()
-          |> Phoenix.Sync.Electric.map_response_body(transform_fun)
-        end)
+        stream
+        |> Enum.to_list()
+        |> IO.iodata_to_binary()
+        |> Phoenix.Sync.Electric.map_response_body(transform_fun)
       end
     end
   end

lib/phoenix/sync/electric/client_adapter.ex

@@ -58,10 +58,14 @@ defmodule Phoenix.Sync.Electric.ClientAdapter do
         end
 
       body =
-        Phoenix.Sync.Electric.map_response_body(
-          response.body,
-          PredefinedShape.transform_fun(shape)
-        )
+        if response.status in 200..299 do
+          Phoenix.Sync.Electric.map_response_body(
+            response.body,
+            PredefinedShape.transform_fun(shape)
+          )
+        else
+          response.body
+        end
 
       conn
       |> put_headers(response.headers)