Skip to content

Commit 0bacbae

Browse files
author
José Valim
committed
Emit warnings for Regex.match?
1 parent 79d8dd0 commit 0bacbae

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

lib/elixir/lib/regex.ex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ defmodule Regex do
116116
117117
"""
118118
def match?(regex(re_pattern: compiled), string) do
119+
_ = return_for(string)
119120
:re.run(string, compiled, [{ :capture, :none }]) == :match
120121
end
121122

lib/mix/lib/mix/task.ex

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,11 @@ defmodule Mix.Task do
6161
end)
6262
end
6363

64-
defp match_tasks(file_name, modules) do
65-
if Regex.match?(~r/Elixir\.Mix\.Tasks\..*\.beam/, file_name) do
66-
mod = Path.rootname(file_name, '.beam') |> list_to_atom
64+
@re_pattern Regex.re_pattern(~r/Elixir\.Mix\.Tasks\..*\.beam$/)
65+
66+
defp match_tasks(filename, modules) do
67+
if :re.run(filename, @re_pattern, [capture: :none]) == :match do
68+
mod = Path.rootname(filename, '.beam') |> list_to_atom
6769
if Code.ensure_loaded?(mod), do: [mod | modules], else: modules
6870
else
6971
modules

0 commit comments

Comments
 (0)