Simplify manifest reading in Mix.Compilers.Test

Author: lexmag

lib/mix/lib/mix/compilers/elixir.ex

@@ -118,12 +118,11 @@ defmodule Mix.Compilers.Elixir do
   Reads the manifest.
   """
   def read_manifest(manifest, compile_path) do
-    # TODO: No longer support file consult once v1.3 is out
     try do
       manifest |> File.read!() |> :erlang.binary_to_term()
     else
-      [@manifest_vsn | t] ->
-        expand_beam_paths(t, compile_path)
+      [@manifest_vsn | data] ->
+        expand_beam_paths(data, compile_path)
       _ ->
         []
     rescue

lib/mix/lib/mix/compilers/test.ex

@@ -160,10 +160,9 @@ defmodule Mix.Compilers.Test do
 
   defp read_manifest() do
     try do
-      manifest() |> File.read!() |> :erlang.binary_to_term()
-    else
-      [@manifest_vsn | t] -> t
-      _ -> []
+      [@manifest_vsn | sources] =
+        manifest() |> File.read!() |> :erlang.binary_to_term()
+      sources
     rescue
       _ -> []
     end

lib/mix/lib/mix/tasks/compile.protocols.ex

@@ -134,9 +134,9 @@ defmodule Mix.Tasks.Compile.Protocols do
 
   defp read_manifest(manifest, output) do
     try do
-      [@manifest_vsn | t] =
+      [@manifest_vsn | metadata] =
         manifest |> File.read! |> :erlang.binary_to_term()
-      t
+      metadata
     rescue
       _ ->
         # If there is no manifest or it is out of date, remove old files