Manually call check_command before eval, closes #2449

Author: José Valim

lib/elixir/src/elixir.erl

@@ -155,14 +155,19 @@ eval_forms(Tree, Binding, Env, Scope) ->
     {atom, _, Atom} ->
       {Atom, Binding, NewEnv, NewScope};
     _  ->
-      {value, Value, NewBinding} = erl_eval(Erl, ParsedBinding),
+      {value, Value, NewBinding} = erl_eval(Erl, ParsedBinding, Env),
       {Value, elixir_scope:dump_binding(NewBinding, NewScope), NewEnv, NewScope}
   end.
 
-erl_eval(Erl, ParsedBinding) ->
+erl_eval(Erl, ParsedBinding, E) ->
+  case erl_eval:check_command([Erl], ParsedBinding) of
+    ok -> ok;
+    {error, Desc} -> elixir_errors:handle_file_error(?m(E, file), Desc)
+  end,
+
   % Below must be all one line for locations to be the same when the stacktrace
   % needs to be extended to the full stacktrace.
-  try erl_eval:expr(Erl, ParsedBinding) catch Class:Exception -> erlang:raise(Class, Exception, get_stacktrace()) end.
+  try erl_eval:expr(Erl, ParsedBinding, none, none, none) catch Class:Exception -> erlang:raise(Class, Exception, get_stacktrace()) end.
 
 get_stacktrace() ->
   Stacktrace = erlang:get_stacktrace(),

lib/elixir/test/elixir/code_test.exs

@@ -28,6 +28,16 @@ defmodule CodeTest do
     assert Code.eval_string("var!(a, Sample) = 1") == {1, [{{:a,Sample},1}]}
   end
 
+  test :eval_binary_errors do
+    msg = "nofile:2: a binary field without size is only allowed at the end of a binary pattern"
+    assert_raise CompileError, msg, fn ->
+      Code.eval_string("""
+      foo = "foo"
+      "\\"" <> bar <> "\\"" = foo
+      """)
+    end
+  end
+
   test :eval_with_unnamed_scopes do
     assert {%RuntimeError{}, [a: %RuntimeError{}]} =
            Code.eval_string("a = (try do (raise \"hello\") rescue e -> e end)")