Normalize exception handling in diagnostics

Author: josevalim

lib/elixir/lib/code.ex

@@ -212,7 +212,7 @@ defmodule Code do
           required(:position) => position(),
           required(:stacktrace) => Exception.stacktrace(),
           required(:span) => {line :: pos_integer(), column :: pos_integer()} | nil,
-          optional(:exception) => Exception.t() | nil,
+          optional(:details) => term(),
           optional(any()) => any()
         }
 

lib/elixir/lib/kernel/parallel_compiler.ex

@@ -901,13 +901,10 @@ defmodule Kernel.ParallelCompiler do
       severity: :error,
       stacktrace: stack,
       span: span,
-      exception: get_exception(reason)
+      details: {kind, reason}
     }
   end
 
-  defp get_exception(exception) when is_exception(exception), do: exception
-  defp get_exception(_reason), do: nil
-
   defp get_line_span(
          _file,
          %{line: line, column: column, end_line: end_line, end_column: end_column},

lib/mix/lib/mix/compilers/elixir.ex

@@ -785,7 +785,7 @@ defmodule Mix.Compilers.Elixir do
       compiler_name: "Elixir",
       stacktrace: stacktrace,
       span: span,
-      details: Map.get(diagnostic, :exception, nil)
+      details: Map.get(diagnostic, :details, nil)
     }
   end
 

lib/mix/lib/mix/task.compiler.ex

@@ -47,7 +47,7 @@ defmodule Mix.Task.Compiler do
             message: IO.chardata(),
             position: Code.position(),
             compiler_name: String.t(),
-            details: Exception.t() | any,
+            details: term(),
             stacktrace: Exception.stacktrace(),
             span: {line :: pos_integer(), column :: pos_integer()} | nil
           }

lib/mix/test/mix/tasks/compile_test.exs

@@ -183,7 +183,7 @@ defmodule Mix.Tasks.CompileTest do
                  position: {2, 20},
                  message: "** (SyntaxError) invalid syntax found on lib/a.ex:2:" <> _,
                  compiler_name: "Elixir",
-                 details: %SyntaxError{}
+                 details: {:error, %SyntaxError{}}
                } = diagnostic
       end)
     end)