Do not raise if a dependency can't be found, closes #1052

Author: José Valim

lib/mix/lib/mix/deps.ex

@@ -66,9 +66,9 @@ defmodule Mix.Deps do
 
   @doc """
   Receives a list of deps names and returns deps records.
-  Raises an error if the dependency does not exist.
+  Logs a message if the dependency could not be found.
   """
-  def by_name!(given, all_deps // all) do
+  def by_name(given, all_deps // all) do
     # Ensure all apps are atoms
     apps = Enum.map given, fn(app) ->
       if is_binary(app), do: binary_to_atom(app), else: app
@@ -81,7 +81,7 @@ defmodule Mix.Deps do
     index = Mix.Dep.__index__(:app)
     Enum.each apps, fn(app) ->
       unless List.keyfind(deps, app, index) do
-        raise Mix.Error, message: "unknown dependency #{app} for env #{Mix.env}"
+        Mix.shell.info message: "unknown dependency #{app} for env #{Mix.env}"
       end
     end
 

lib/mix/lib/mix/project.ex

@@ -259,9 +259,8 @@ defmodule Mix.Project do
     end
 
     unless :digraph_utils.is_acyclic(graph) do
-      Mix.shell.error "Could not dependency sort umbrella projects. " <>
+      raise Mix.Error, message: "Could not dependency sort umbrella projects. " <>
         "There are cycles in the dependency graph."
-      exit(1)
     end
 
     vertices = :digraph_utils.topsort(graph)

lib/mix/lib/mix/tasks/deps.clean.ex

@@ -12,12 +12,12 @@ defmodule Mix.Tasks.Deps.Clean do
   the repositories, unless --unlock is given.
   """
 
-  import Mix.Deps, only: [all: 0, by_name!: 1, format_dep: 1]
+  import Mix.Deps, only: [all: 0, by_name: 1, format_dep: 1]
 
   def run(args) do
     case OptionParser.parse(args, switches: [unlock: :boolean]) do
       { opts, [] }   -> do_clean all, opts
-      { opts, args } -> do_clean by_name!(args), opts
+      { opts, args } -> do_clean by_name(args), opts
     end
   end
 

lib/mix/lib/mix/tasks/deps.compile.ex

@@ -24,7 +24,7 @@ defmodule Mix.Tasks.Deps.Compile do
 
   """
 
-  import Mix.Deps, only: [ all: 0, available?: 1, by_name!: 2, compile_paths: 1,
+  import Mix.Deps, only: [ all: 0, available?: 1, by_name: 2, compile_paths: 1,
                            depending: 2, format_dep: 1, make?: 1, mix?: 1, rebar?: 1 ]
 
   def run(args) do
@@ -33,7 +33,7 @@ defmodule Mix.Tasks.Deps.Compile do
         do_compile Enum.filter(all, available?(&1))
       { _, tail } ->
         all_deps = all
-        deps = by_name!(tail, all_deps)
+        deps = by_name(tail, all_deps)
         do_compile(deps ++ depending(deps, all_deps))
     end
   end

lib/mix/lib/mix/tasks/deps.get.ex

@@ -10,17 +10,18 @@ defmodule Mix.Tasks.Deps.Get do
 
   ## Command line options
 
-  * `--no-compile` skip compilation of dependencies
-  * `--quiet` only output error messages or if an action was performed
+  * `--no-compile` - skip compilation of dependencies
+  * `--quiet` - do not output success message
+
   """
 
-  import Mix.Deps, only: [all: 2, by_name!: 1, format_dep: 1, check_lock: 2, out_of_date?: 1]
+  import Mix.Deps, only: [all: 2, by_name: 1, format_dep: 1, check_lock: 2, out_of_date?: 1]
 
   def run(args) do
     { opts, rest } = OptionParser.parse(args, switches: [no_compile: :boolean, quiet: :boolean])
 
     if rest != [] do
-      { _, acc } = Enum.map_reduce by_name!(rest), init, deps_getter(&1, &2)
+      { _, acc } = Enum.map_reduce by_name(rest), init, deps_getter(&1, &2)
     else
       acc = all(init, deps_getter(&1, &2))
     end

lib/mix/lib/mix/tasks/deps.update.ex

@@ -13,18 +13,18 @@ defmodule Mix.Tasks.Deps.Update do
 
   ## Command line options
 
-  * `--no-compile` skip compilation of dependencies
+  * `--no-compile` - skip compilation of dependencies
   """
 
-  import Mix.Deps, only: [ all: 0, all: 2, available?: 1, by_name!: 2,
+  import Mix.Deps, only: [ all: 0, all: 2, available?: 1, by_name: 2,
                            depending: 2, format_dep: 1 ]
 
   def run(args) do
     { opts, rest } = OptionParser.parse(args, switches: [no_compile: :boolean])
 
     if rest != [] do
       all_deps = all
-      deps = Enum.map by_name!(rest, all_deps), check_unavailable!(&1)
+      deps = Enum.map by_name(rest, all_deps), check_unavailable!(&1)
       deps = deps ++ depending(deps, all_deps)
       { _, acc } = Enum.map_reduce deps, init, deps_updater(&1, &2)
     else

lib/mix/lib/mix/tasks/escriptize.ex

@@ -61,12 +61,11 @@ defmodule Mix.Tasks.Escriptize do
 
     cond do
       !script_name ->
-        Mix.shell.error "Could not generate escript, no name given, set :escript_name " <>
-                        "or :app in the project settings"
-        :noop
+        raise Mix.Error, message: "Could not generate escript, no name given, " <>
+          "set :escript_name or :app in the project settings"
       beams == [] ->
-        Mix.shell.error "Could not generate escript #{filename}, no beam files available"
-        :noop
+        raise Mix.Error, message: "Could not generate escript #{filename}, " <>
+          "no beam files available"
       force or Mix.Utils.stale?(beams, [filename]) ->
         files = gen_main(script_name, project[:escript_main_module])
         files = files ++ all_files()
@@ -98,6 +97,7 @@ defmodule Mix.Tasks.Escriptize do
 
         set_perms(filename)
         Mix.shell.info "Generated escript #{filename}"
+        :ok
       true ->
         :noop
     end