Add new recommended rule: template-no-let-reference (#1977)

Author: bmish

README.md

@@ -241,7 +241,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [no-empty-glimmer-component-classes](docs/rules/no-empty-glimmer-component-classes.md)     | disallow empty backing classes for Glimmer components                                                          | ✅  |    |    |
 | [no-tracked-properties-from-args](docs/rules/no-tracked-properties-from-args.md)           | disallow creating @tracked properties from this.args                                                           | ✅  |    |    |
 | [template-indent](docs/rules/template-indent.md)                                           | enforce consistent indentation for gts/gjs templates                                                           |    | 🔧 |    |
-| [template-no-let-reference](docs/rules/template-no-let-reference.md)                       | disallow referencing let variables in \<template\>                                                             |    |    |    |
+| [template-no-let-reference](docs/rules/template-no-let-reference.md)                       | disallow referencing let variables in \<template\>                                                             | ✅  |    |    |
 
 ### jQuery
 

docs/rules/template-no-let-reference.md

@@ -1,5 +1,7 @@
 # ember/template-no-let-reference
 
+💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/ember-cli/eslint-plugin-ember#-configurations).
+
 <!-- end auto-generated rule header -->
 
 Disallows referencing let/var variables in templates.

lib/recommended-rules.js

@@ -73,6 +73,7 @@ module.exports = {
   "ember/require-tagless-components": "error",
   "ember/require-valid-css-selector-in-test-helpers": "error",
   "ember/routes-segments-snake-case": "error",
+  "ember/template-no-let-reference": "error",
   "ember/use-brace-expansion": "error",
   "ember/use-ember-data-rfc-395-imports": "error"
 }

lib/rules/template-no-let-reference.js

@@ -5,7 +5,7 @@ module.exports = {
     docs: {
       description: 'disallow referencing let variables in \\<template\\>',
       category: 'Ember Octane',
-      recommended: false,
+      recommended: true,
       url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-let-reference.md',
     },
     fixable: null,

tests/__snapshots__/recommended.js.snap

@@ -70,6 +70,7 @@ exports[`recommended rules has the right list 1`] = `
   "require-tagless-components",
   "require-valid-css-selector-in-test-helpers",
   "routes-segments-snake-case",
+  "template-no-let-reference",
   "use-brace-expansion",
   "use-ember-data-rfc-395-imports",
 ]