lint:fix

Author: NullVoxPopuli

README.md

@@ -172,7 +172,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 ![gjs logo](/docs/svgs/gjs.svg) Set in the `recommended-gjs` [configuration](https://github.com/ember-cli/eslint-plugin-ember#-configurations).\
 ![gts logo](/docs/svgs/gts.svg) Set in the `recommended-gts` [configuration](https://github.com/ember-cli/eslint-plugin-ember#-configurations).\
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
-💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
+💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 ### Components
 

docs/rules/no-unused-services.md

@@ -1,6 +1,6 @@
 # ember/no-unused-services
 
-💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

docs/rules/route-path-style.md

@@ -1,6 +1,6 @@
 # ember/route-path-style
 
-💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

eslint.config.js

@@ -32,23 +32,10 @@ module.exports = [
   eslintPluginN.configs['flat/recommended'],
   eslintPluginUnicorn.configs['flat/recommended'],
 
-  {
-    ignores: [
-      'coverage/',
-      'node_modules/',
-      'lib/recommended-rules.js',
-      'lib/recommended-rules-gjs.js',
-      'lib/recommended-rules-gts.js',
-      'tests/__snapshots__/',
-
-      // # Contains <template> in js markdown
-      'docs/rules/no-empty-glimmer-component-classes.md',
-      'docs/rules/template-no-let-reference.md',
-    ],
-  },
   {
     languageOptions: {
       parser: babelEslintParser,
+      sourceType: 'script',
       parserOptions: {
         ecmaVersion: 2022,
         sourceType: 'script',
@@ -152,6 +139,8 @@ module.exports = [
       'import/no-webpack-loader-syntax': 'error',
       'import/unambiguous': 'error',
 
+      'n/no-unsupported-features/node-builtins': 'off',
+
       // Unicorn rules:
       'unicorn/no-array-callback-reference': 'off',
       'unicorn/no-array-method-this-argument': 'off',
@@ -183,6 +172,7 @@ module.exports = [
     // Markdown code samples in documentation:
     files: ['**/*.md/*.js'],
     languageOptions: {
+      sourceType: 'module',
       parserOptions: {
         sourceType: 'module',
         ecmaFeatures: { legacyDecorators: true },
@@ -232,6 +222,23 @@ module.exports = [
       'import/no-named-as-default-member': 'off',
       'import/no-unresalved': 'off',
       'import/no-missing-import': 'off',
+
+      // vite config format does not match regex
+      'filenames/match-regex': 'off',
     },
   },
+  {
+    ignores: [
+      'coverage/',
+      'node_modules/',
+      'lib/recommended-rules.js',
+      'lib/recommended-rules-gjs.js',
+      'lib/recommended-rules-gts.js',
+      'tests/__snapshots__/',
+
+      // # Contains <template> in js markdown
+      'docs/rules/no-empty-glimmer-component-classes.md',
+      'docs/rules/template-no-let-reference.md',
+    ],
+  },
 ];

lib/rules/no-get.js

@@ -224,7 +224,7 @@ module.exports = {
       );
     }
 
-    let proxyObjects = [];
+    const proxyObjects = [];
     let currentClassWithUnknownPropertyMethod = null;
 
     let importedGetName;

package.json

@@ -44,8 +44,8 @@
     "lint:eslint-docs": "npm-run-all \"update:eslint-docs -- --check\"",
     "lint:eslint-docs:fix": "npm-run-all \"update:eslint-docs\"",
     "lint:fix": "npm-run-all \"lint:*:fix\"",
-    "lint:js": "eslint --cache .",
-    "lint:js:fix": "npm-run-all \"lint:js -- --fix\"",
+    "lint:js": "eslint .",
+    "lint:js:fix": "pnpm lint:js --fix",
     "lint:package-json": "npmPkgJsonLint .",
     "lint:package-json-sorting": "sort-package-json --check",
     "lint:package-json-sorting:fix": "sort-package-json package.json",
@@ -89,7 +89,7 @@
     "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-import": "^2.29.0",
     "eslint-plugin-markdown": "^3.0.1",
-    "eslint-plugin-n": "^16.2.0",
+    "eslint-plugin-n": "^17.11.1",
     "eslint-plugin-prettier": "^5.0.1",
     "eslint-plugin-unicorn": "^51.0.0",
     "eslint-remote-tester": "^3.0.1",
@@ -116,10 +116,10 @@
       "optional": true
     }
   },
+  "packageManager": "pnpm@9.12.2",
   "engines": {
     "node": "18.* || 20.* || >= 21"
   },
-  "packageManager": "pnpm@9.12.2",
   "publishConfig": {
     "registry": "https://registry.npmjs.org"
   },

pnpm-lock.yaml

@@ -11,7 +11,6 @@ describe('config setup is correct', function () {
     const filePath = path.join(__dirname, '..', 'lib', 'config');
     const files = readdirSync(filePath);
 
-    // eslint-disable-next-line jest/prefer-strict-equal
     expect(CONFIG_NAMES).toEqual(
       files.filter((file) => !file.startsWith('.')).map((file) => file.replace('.js', ''))
     );

tests/config-setup.js

@@ -491,7 +491,6 @@ describe('template-vars', () => {
     for (const scenario of valid) {
       const { code, filename, parser } = scenario;
 
-      // eslint-disable-next-line jest/valid-title
       it(code, async () => {
         const eslint = initESLint(parser);
         const results = await eslint.lintText(code, {
@@ -511,7 +510,6 @@ describe('template-vars', () => {
     for (const scenario of invalid) {
       const { code, filename, errors, parser } = scenario;
 
-      // eslint-disable-next-line jest/valid-title
       it(code, async () => {
         const eslint = initESLint(parser);
         const results = await eslint.lintText(code, {

tests/lib/rules-preprocessor/gjs-gts-parser-test.js

@@ -496,7 +496,7 @@ describe('reportUnorderedProperties', () => {
         undefined,
         importControllerName
       );
-      expect(context.report).toHaveBeenCalled(); // eslint-disable-line jest/prefer-called-with
+      expect(context.report).toHaveBeenCalled();
     });
   });
 
@@ -558,7 +558,7 @@ describe('reportUnorderedProperties', () => {
         undefined,
         importControllerName
       );
-      expect(context.report).toHaveBeenCalled(); // eslint-disable-line jest/prefer-called-with
+      expect(context.report).toHaveBeenCalled();
     });
   });
 });