Skip to content

Commit a875ffe

Browse files
committed
Run tests with latest Ember CLI
Use canary version of ember-cli on master branch, until we ge get a stable/beta release on npm, which includes better support of `--typescript` ([PR](ember-cli/ember-cli#10283)). Cleans up previous weirdness.
1 parent 3c7d677 commit a875ffe

File tree

5 files changed

+1886
-2102
lines changed

5 files changed

+1886
-2102
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,22 @@ jobs:
4343
# waiting on a an api from vitest for querying
4444
# the list of tests ahead of time before running them.
4545
#
46-
# It would be great if vitest had a flag to give us the JSON of all the tests,
47-
# so we could be sure we don't miss anything
46+
# It would be great if vitest had a flag to give us the JSON of all the tests,
47+
# so we could be sure we don't miss anything
4848
# and then generate this list from a previous C.I. job
4949
slow-test:
5050
- defaults with npm
5151
- defaults with yarn
5252
- defaults with pnpm
5353

54+
# TypeScript
55+
- typescript with npm
56+
- typescript with yarn
57+
- typescript with pnpm
58+
5459
# flags
5560
- addon-location
5661
- test-app-location
57-
- typescript
5862
- addon-only
5963

6064
# existing monorepo
@@ -64,6 +68,5 @@ jobs:
6468
steps:
6569
- uses: actions/checkout@v3
6670
- uses: ./.github/actions/pnpm
67-
- run: pnpm add --global ember-cli yarn
6871
- run: pnpm vitest --testNamePattern "${{ matrix.slow-test }}"
6972
working-directory: tests

index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,12 +176,17 @@ module.exports = {
176176

177177
if (options.typescript) {
178178
const needsVersion = '4.9.0-beta.0';
179+
const recommendedVersion = '5.2.0-beta.0';
179180
const hasVersion = this.project.emberCLIVersion();
180181

181182
if (lt(hasVersion, needsVersion)) {
182183
this.ui.writeWarnLine(
183184
`Your version ${hasVersion} of Ember CLI does not support the --typescript flag yet. Please run \`ember install ember-cli-typescript\` in the ${testAppInfo.location} folder manually!`
184185
);
186+
} else if (lt(hasVersion, recommendedVersion)) {
187+
this.ui.writeWarnLine(
188+
`We recommend using Ember CLI >= ${recommendedVersion} for the best blueprint support when using TypeScript!`
189+
);
185190
}
186191
}
187192
},

0 commit comments

Comments
 (0)