Response.url is somewhere listed as optional and elsewhere not
#1908
Unanswered
septatrix
asked this question in
Potential Issue
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In the method signature it is declared as optional however in the docs it is stated as being non-optional.
The latter seems to make more sense as the value is directly linked to the url of the request which should not be none.
This currently leeds to some false positives with mypy in our codebase.
httpx/httpx/_models.py
Lines 1304 to 1309 in 62b1666
httpx/docs/api.md
Line 59 in 62b1666
Beta Was this translation helpful? Give feedback.
All reactions