Skip to content

Core changes for Accessibility break Custom Reports search form #5

@drn05r

Description

@drn05r

Changes to EPrints 3.4.2 to improve Accessibility have created an issue where fields for all search forms under Custom Reports tab are displayed at once. This is due to a move from using table, tr and td elements to using div elements. This can be remedied by switching the current table element used on line 638 of lib/plugins/EPrints/Plugin/Screen/Report.pm from:

my $table = $repo->make_element( "table", class=>"ep_search_fields", id=>$formid, style=>"display: none" );

to:

my $table = $repo->make_element( "div", class=>"ep_search_fields ep_tabl e", id=>$formid, style=>"display: none" );

However, this will then break things for pre 3.4.2 versions of EPrints. Therefore some conditional statement to check which version should be used. There does not currently seem to be an easy way of checking whether a version is higher or lower than another. So the conditional statement might be a little long-winded.

Sub-issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions