P2 download race condition

[nedtwigg]

When used in a Spotless build, it is sometimes triggering this race condition:

Caused by: java.lang.RuntimeException: java.nio.file.FileAlreadyExistsException: /home/jenkins/.m2/repository/dev/equo/p2-data/bundle-pool/https-eclipse-p2-mirror.com-p2-4.34-/com.sun.jna_5.15.0.v20240915-2000.jar
	at dev.equo.solstice.p2.Unchecked.wrap(Unchecked.java:25)
	at dev.equo.solstice.p2.P2QueryResult.<init>(P2QueryResult.java:38)
	at dev.equo.solstice.p2.P2Model.query(P2Model.java:137)
	at com.diffplug.spotless.extra.EquoBasedStepBuilder.lambda$build$0(EquoBasedStepBuilder.java:128)
	... 82 more
Caused by: java.nio.file.FileAlreadyExistsException: /home/jenkins/.m2/repository/dev/equo/p2-data/bundle-pool/https-eclipse-p2-mirror.com-p2-4.34-/com.sun.jna_5.15.0.v20240915-2000.jar
	at dev.equo.solstice.p2.JarCache.download(JarCache.java:65)
	at dev.equo.solstice.p2.P2Client.download(P2Client.java:76)
	at dev.equo.solstice.p2.P2QueryResult.<init>(P2QueryResult.java:35)
	... 84 more

[bguerin]

Or the other way round

Caused by: java.nio.file.NoSuchFileException: /var/jenkins_home/.m2/repository/dev/equo/p2-data/bundle-pool/https-download.eclipse.org-eclipse-updates-4.34-R-4.34-202411201800-/com.sun.jna_5.15.0.v20240915-2000.jar
      at sun.nio.fs.UnixException.translateToIOException (UnixException.java:92)
      at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:106)
      at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:111)
      at sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes (UnixFileAttributeViews.java:55)
      at sun.nio.fs.UnixFileSystemProvider.readAttributes (UnixFileSystemProvider.java:171)
      at sun.nio.fs.LinuxFileSystemProvider.readAttributes (LinuxFileSystemProvider.java:99)
      at java.nio.file.Files.readAttributes (Files.java:1854)
      at java.util.zip.ZipFile$Source.get (ZipFile.java:1445)
      at java.util.zip.ZipFile$CleanableResource.<init> (ZipFile.java:724)
      at java.util.zip.ZipFile.<init> (ZipFile.java:251)
      at java.util.zip.ZipFile.<init> (ZipFile.java:180)
      at java.util.jar.JarFile.<init> (JarFile.java:345)
      at java.util.jar.JarFile.<init> (JarFile.java:316)
      at java.util.jar.JarFile.<init> (JarFile.java:282)
      at dev.equo.solstice.NestedJars$1.listNestedJars (NestedJars.java:262)
      at dev.equo.solstice.NestedJars.extractAllNestedJars (NestedJars.java:288)
      at dev.equo.solstice.NestedJars.extractAllNestedJars (NestedJars.java:283)
      at com.diffplug.spotless.extra.EquoBasedStepBuilder.lambda$build$0 (EquoBasedStepBuilder.java:139)
      at com.diffplug.spotless.JarState$Promised.get (JarState.java:73)
      at com.diffplug.spotless.JarState$Promised.writeObject (JarState.java:86)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:1072)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1529)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.defaultWriteFields (ObjectOutputStream.java:1585)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1542)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.defaultWriteFields (ObjectOutputStream.java:1585)
      at java.io.ObjectOutputStream.defaultWriteObject (ObjectOutputStream.java:451)
      at com.diffplug.spotless.FormatterStepSerializationRoundtrip.writeObject (FormatterStepSerializationRoundtrip.java:81)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:1072)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1529)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.defaultWriteFields (ObjectOutputStream.java:1585)
      at java.io.ObjectOutputStream.defaultWriteObject (ObjectOutputStream.java:451)
      at com.diffplug.spotless.FormatterStepSerializationRoundtrip$HackClone.writeObject (FormatterStepSerializationRoundtrip.java:118)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:1072)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1529)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.writeObject (ObjectOutputStream.java:358)
      at com.diffplug.spotless.ConfigurationCacheHackList.writeObject (ConfigurationCacheHackList.java:76)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:1072)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1529)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.defaultWriteFields (ObjectOutputStream.java:1585)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1542)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.defaultWriteFields (ObjectOutputStream.java:1585)
      at java.io.ObjectOutputStream.defaultWriteObject (ObjectOutputStream.java:451)
      at com.diffplug.spotless.FormatterStepSerializationRoundtrip.writeObject (FormatterStepSerializationRoundtrip.java:81)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:1072)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1529)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.writeObject (ObjectOutputStream.java:358)
      at java.util.ArrayList.writeObject (ArrayList.java:948)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:1072)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1529)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.writeObject (ObjectOutputStream.java:358)
      at com.diffplug.spotless.Formatter.writeObject (Formatter.java:54)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:1072)
      at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1529)
      at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1451)
      at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1194)
      at java.io.ObjectOutputStream.writeObject (ObjectOutputStream.java:358)
      at com.diffplug.spotless.maven.incremental.PluginFingerprint.digest (PluginFingerprint.java:109)
      at com.diffplug.spotless.maven.incremental.PluginFingerprint.from (PluginFingerprint.java:48)
      at com.diffplug.spotless.maven.incremental.IndexBasedChecker.create (IndexBasedChecker.java:43)
      at com.diffplug.spotless.maven.incremental.UpToDateChecker.forProject (UpToDateChecker.java:39)
      at com.diffplug.spotless.maven.AbstractSpotlessMojo.createUpToDateChecker (AbstractSpotlessMojo.java:411)
      at com.diffplug.spotless.maven.AbstractSpotlessMojo.execute (AbstractSpotlessMojo.java:251)
      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
      at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
      at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
      at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
      at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
      at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
      at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
      at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
      at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
      at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
      at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
      at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
      at java.lang.reflect.Method.invoke (Method.java:580)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
      at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
      at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)