-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Improve readability of Log Levels #5735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Formatted log levels in a table instead of a bullet list to make the association of the level and description more clear.
WalkthroughReformatted the Log Levels section in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/components/logger.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
- Do not generate or add any sequence diagrams
Files:
content/components/logger.md
🧠 Learnings (2)
📓 Common learnings
Learnt from: jesserockz
Repo: esphome/esphome-docs PR: 4865
File: .github/workflows/needs-docs.yml:0-0
Timestamp: 2025-05-01T03:29:47.922Z
Learning: In the esphome-docs repository, the "current" label is automatically added by a bot to pull requests, making it a reliable indicator for the target branch.
📚 Learning: 2025-08-11T12:34:51.506Z
Learnt from: oarcher
Repo: esphome/esphome-docs PR: 5224
File: components/logger.rst:254-261
Timestamp: 2025-08-11T12:34:51.506Z
Learning: In ESPHome logger configuration, the `initial_level` option works together with the `logs` tag mapping. When `initial_level` is set (e.g., to ERROR), it sets the global runtime log level, but tags specified in the `logs` section will use their specified levels regardless of the `initial_level` setting. This means you can compile verbose logs with `level: VERBOSE`, start with minimal logging using `initial_level: ERROR`, and still have specific components like `wifi: VERBOSE` remain verbose without needing `on_boot` automation and `logger.set_level` actions.
Applied to files:
content/components/logger.md
🪛 GitHub Actions: CI
content/components/logger.md
[error] 137-137: MD033/no-inline-html Inline HTML [Element: br]
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (1)
content/components/logger.md (1)
129-137: Excellent restructuring of log levels into table format.The conversion from bullet points to a table significantly improves the visual association between each log level, its color representation, and its description. The information content is well-preserved, and the layout is clean and easy to scan.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Description:
Change the format of log levels to a table instead of a bullet list to make the association of the level and description more clear.
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.New Component Images
If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.
To generate a component image:
Comment on this pull request with the following command, replacing
COMPONENT_NAMEwith your component name in UPPER_CASE format with underscores (e.g.,BME280,SHT3X,DALLAS_TEMP):The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.
Extract the SVG file and place it in the
images/folder of this repository.Use the image in your component's index table entry in
/components/index.rst.Example: For a component called "DHT22 Temperature Sensor", use: