Qu0b/add bal test cases #1812
Merged
Qu0b/add bal test cases #1812
+1,204
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qu0b
changed the base branch from
forks/amsterdam
to
eips/amsterdam/eip-7928
nerolation
reviewed
Nov 26, 2025
Member
jochem-brouwer
left a comment
jochem-brouwer
left a comment
There was a problem hiding this comment.
Hey Stefan 😄 👍 We met at Devconnect!! 🥳
Very impressive edge cases! I left a few comments on them, also some clarifications or just some notes. Thanks a lot 😄 👍
qu0b
commented
Nov 28, 2025
Contributor
Author
|
Recent run with the new test cases against besu and nethermind. 
|
Contributor
qu0b
force-pushed
the
qu0b/add-bal-test-cases
branch
from
e4c7fe1 to
98c2154
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1812 +/- ##
==========================================================
Coverage ? 82.46%
==========================================================
Files ? 797
Lines ? 47987
Branches ? 4341
==========================================================
Hits ? 39574
Misses ? 7927
Partials ? 486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mirgee
pushed a commit
to mirgee/execution-specs
that referenced
this pull request
Dec 5, 2025
…#1812) Co-authored-by: Mario Vega <marioevz@gmail.com>
fselmo
force-pushed
the
qu0b/add-bal-test-cases
branch
2 times, most recently
from
056eeae to
6aae2fb
Compare
fselmo
force-pushed
the
qu0b/add-bal-test-cases
branch
from
6aae2fb to
320670f
Compare
fselmo
force-pushed
the
qu0b/add-bal-test-cases
branch
from
4cfbc32 to
4c0cc53
Compare
fselmo
force-pushed
the
qu0b/add-bal-test-cases
branch
from
4c0cc53 to
1518655
Compare
fselmo
added a commit
that referenced
this pull request
Dec 9, 2025
* rebase onto upstream * chore(fix) balance check in call before target access * merge test cases with usptream * merge test cases with usptream * chore(fix) format with ruff * chore(fix) revert call changes and add target to bal * merge test cases with usptream * improve wording * chore(formate) fix formatting and line length * refactor(test-tests): Use pre API where possible; explicit check for none in BAL * refactor(test-tests): Refactor opcode tests to bal opcodes test file --------- Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo
added a commit
that referenced
this pull request
Dec 9, 2025
* rebase onto upstream * chore(fix) balance check in call before target access * merge test cases with usptream * merge test cases with usptream * chore(fix) format with ruff * chore(fix) revert call changes and add target to bal * merge test cases with usptream * improve wording * chore(formate) fix formatting and line length * refactor(test-tests): Use pre API where possible; explicit check for none in BAL * refactor(test-tests): Refactor opcode tests to bal opcodes test file --------- Co-authored-by: fselmo <fselmo2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Implement new BAL (Block Access List) tests with full test implementations:
test_bal_create2_collision- CREATE2 address collision handlingtest_bal_create_selfdestruct_to_self_with_call- Init code with external call then selfdestruct to selftest_bal_selfdestruct_to_7702_delegation- SELFDESTRUCT to EIP-7702 delegated accounttest_bal_revert_insufficient_funds- CALL failure due to insufficient balancetest_bal_lexicographic_address_ordering- Strict byte-wise address ordering validation with endian-trap addressestest_bal_transient_storage_not_tracked- EIP-1153 transient storage exclusiontest_bal_selfdestruct_to_precompile- SELFDESTRUCT with precompile beneficiarytest_bal_all_transaction_types- All 5 tx types (Legacy, EIP-2930, EIP-1559, Blob, EIP-7702) in single blocktest_bal_create_early_failure- CREATE failure before track_addresstest_bal_withdrawal_to_7702_delegation- Withdrawal to EIP-7702 delegated account