-
Notifications
You must be signed in to change notification settings - Fork 392
fix(spec,tests): Change BAL to List[AccountChange] #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spec,tests): Change BAL to List[AccountChange] #1844
Conversation
Codecov Reportโ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1844 +/- ##
==========================================================
Coverage ? 86.62%
==========================================================
Files ? 797
Lines ? 47984
Branches ? 4341
==========================================================
Hits ? 41566
Misses ? 5843
Partials ? 575
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
fselmo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gurukamath I added the bal in the genesis here and fixed the fill with your changes. Lmk what you think but this lgtm.
LGTM! However, the genesis RLP check is enabled now for |
Right, this was my expectation here. We plan to make a new release this week ๐๐ผ |
323d882
into
ethereum:eips/amsterdam/eip-7928
* fix(spec): update BAL type * fix(tests): run amsterdam jsons * fix(test-specs): Add BAL to genesis beyond Amsterdam fork --------- Co-authored-by: fselmo <fselmo2@gmail.com>
* fix(spec): update BAL type * fix(tests): run amsterdam jsons * fix(test-specs): Add BAL to genesis beyond Amsterdam fork --------- Co-authored-by: fselmo <fselmo2@gmail.com>
๐๏ธ Description
The EIP does the follwoing updates
โ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture