From 60f262e2953463a46a430f0cc5e231ba4164279f Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 4 Dec 2025 19:43:07 +0000 Subject: [PATCH 01/11] enhance(ci): Add EIP Tracker Issue Template --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 77 +++++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/eip-tracker.yaml diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml new file mode 100644 index 0000000000..a13cd49f70 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -0,0 +1,77 @@ +name: "EIP Implementation Tracker" +description: "Track specification and testing progress for an EIP" +title: "EIP ${{ form.eip_number }} Progress Tracker" +labels: + - A-spec-specs + - A-spec-tests + - C-eip + - C-test + +body: + - type: input + id: eip_number + attributes: + label: "EIP Number" + description: "Enter the EIP number (digits only)." + placeholder: "e.g., 8024" + validations: + required: true + + - type: input + id: eip_title + attributes: + label: "EIP Title" + description: "Copy the title from the EIP." + placeholder: "e.g., Backwards compatible SWAPN, DUPN, EXCHANGE" + validations: + required: true + + - type: dropdown + id: fork + attributes: + label: "Fork" + description: | + Specify the target fork **only if the EIP has reached the CFI stage**. + More info: https://eips.ethereum.org/EIPS/eip-7723#considered-for-inclusion + options: + - TBD + - amsterdam + - bogota + validations: + required: true + + - type: markdown + attributes: + value: | + ## EIP ${{ form.eip_number }}: ${{ form.eip_title }} + + **Link:** https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }} + + ## Target Fork + + Fork **${{ form.fork }}** + + - [ ] Add issue to fork milestone (if applicable). + + ## Ownership + + Owner(s): **TBD** + + ## Specification + Testing Status + + - [ ] Testing complexity assessed and documented. + - [ ] Specification implementation merged to `eips/${{ form.fork }}/eip-${{ form.eip_number }}`. + - [ ] Specification updates merged to the corresponding `forks/${{ form.fork }}` branch. + - [ ] Required testing framework modifications implemented. + - [ ] Test suite implemented. + - [ ] Full code coverage for all changes. + - [ ] Testing checklist complete + (https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md). + - [ ] No regressions or failures in tests from prior forks (including static tests). + - [ ] Hardening session completed. + - [ ] Benchmarking performed and results documented. + + ## Process Status + + - [ ] Client implementation prototypes done. + - [ ] EIP included in a devnet. \ No newline at end of file From 2b049864d281ceb6aecce82544eabbf1f35ee3de Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 4 Dec 2025 19:54:47 +0000 Subject: [PATCH 02/11] Add note and paraphrase. --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index a13cd49f70..4de1b9a033 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -57,6 +57,8 @@ body: Owner(s): **TBD** + **Important note:** A specifications specialist and a testing specialist should ideally share ownership of the EIP. + ## Specification + Testing Status - [ ] Testing complexity assessed and documented. @@ -73,5 +75,5 @@ body: ## Process Status - - [ ] Client implementation prototypes done. + - [ ] Hive tests passing on all implementations. - [ ] EIP included in a devnet. \ No newline at end of file From bd7219b575651da2a22766514df0e5462f85de8c Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:14:20 +0100 Subject: [PATCH 03/11] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 4de1b9a033..4ccb8fb1cf 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -57,7 +57,8 @@ body: Owner(s): **TBD** - **Important note:** A specifications specialist and a testing specialist should ideally share ownership of the EIP. + [!IMPORTANT] + A specifications specialist and a testing specialist should ideally share ownership of the EIP. ## Specification + Testing Status From ab1a771f26ec147fe74997a0d8cb0624d693ae1d Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:26:28 +0100 Subject: [PATCH 04/11] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 4ccb8fb1cf..2c5983d12d 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -77,4 +77,5 @@ body: ## Process Status - [ ] Hive tests passing on all implementations. - - [ ] EIP included in a devnet. \ No newline at end of file + - [ ] EIP included in a devnet. + \ No newline at end of file From a3e637f3e553eca9d768a35ba765b7d38310582c Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:29:04 +0100 Subject: [PATCH 05/11] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 2c5983d12d..81b06a709c 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -68,8 +68,8 @@ body: - [ ] Required testing framework modifications implemented. - [ ] Test suite implemented. - [ ] Full code coverage for all changes. - - [ ] Testing checklist complete - (https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md). + - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete + . - [ ] No regressions or failures in tests from prior forks (including static tests). - [ ] Hardening session completed. - [ ] Benchmarking performed and results documented. From b3a4b061eb24fed9093f58a355ec2e39e624898f Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:29:40 +0100 Subject: [PATCH 06/11] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 81b06a709c..480c5b36d0 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -43,9 +43,7 @@ body: - type: markdown attributes: value: | - ## EIP ${{ form.eip_number }}: ${{ form.eip_title }} - - **Link:** https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }} + ## [EIP-${{ form.eip_number }}](https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }}) ## Target Fork From 277fc53e50964034808de7623c137892e24dd338 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:27:38 +0000 Subject: [PATCH 07/11] Review feedback --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 480c5b36d0..ed79a1f68f 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -45,34 +45,34 @@ body: value: | ## [EIP-${{ form.eip_number }}](https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }}) - ## Target Fork + ### Target Fork Fork **${{ form.fork }}** - - [ ] Add issue to fork milestone (if applicable). - - ## Ownership + ### Instructions - Owner(s): **TBD** + - [ ] Assign issue to EIP specification and testing owner(s). + + > [!IMPORTANT] + > A specifications specialist and a testing specialist should ideally share ownership of the EIP. - [!IMPORTANT] - A specifications specialist and a testing specialist should ideally share ownership of the EIP. + - [ ] Add the issue to the target fork milestone if applicable (i.e., the EIP is at least in the (CFI stage)[https://eips.ethereum.org/EIPS/eip-7723#considered-for-inclusion]). - ## Specification + Testing Status + ### Specification + Testing Status - [ ] Testing complexity assessed and documented. - - [ ] Specification implementation merged to `eips/${{ form.fork }}/eip-${{ form.eip_number }}`. + - [ ] Specification implementation merged to `eips/${{ form.fork }}/eip-${{ form.eip_number }}` *(skip if the fork branch merge below is already complete)*. - [ ] Specification updates merged to the corresponding `forks/${{ form.fork }}` branch. + - [ ] EIP updates proposed in case of architectural choices surfaced during implementation. - [ ] Required testing framework modifications implemented. - [ ] Test suite implemented. - [ ] Full code coverage for all changes. - - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete - . + - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete. - [ ] No regressions or failures in tests from prior forks (including static tests). - [ ] Hardening session completed. - [ ] Benchmarking performed and results documented. - ## Process Status + ### Process Status - [ ] Hive tests passing on all implementations. - [ ] EIP included in a devnet. From 1c9fd86dd325c24a9b363ea53f378967bd97eb17 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 16:57:18 +0100 Subject: [PATCH 08/11] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index ed79a1f68f..9afa24e9ca 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -71,6 +71,8 @@ body: - [ ] No regressions or failures in tests from prior forks (including static tests). - [ ] Hardening session completed. - [ ] Benchmarking performed and results documented. + - [ ] Ran tests using `execute` to ensure compatibility, and marked specific tests to be skipped when they cannot be executed on live networks. + - [ ] Added Mainnet-marked tests ([example test](https://github.com/ethereum/execution-specs/blob/2a6f9ee98ba7c0d04c7d523a0ea0ee8a98a5c418/tests/osaka/eip7939_count_leading_zeros/test_eip_mainnet.py)). ### Process Status From 852e75c09d24efbc050a64b01cf32e3ed21948f0 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Mon, 8 Dec 2025 14:46:29 +0100 Subject: [PATCH 09/11] Apply suggestions from code review Co-authored-by: felipe --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 9afa24e9ca..9b328e50ac 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -56,7 +56,7 @@ body: > [!IMPORTANT] > A specifications specialist and a testing specialist should ideally share ownership of the EIP. - - [ ] Add the issue to the target fork milestone if applicable (i.e., the EIP is at least in the (CFI stage)[https://eips.ethereum.org/EIPS/eip-7723#considered-for-inclusion]). + - [ ] Add the issue to the target fork milestone if applicable (i.e., the EIP is at least in the [CFI stage](https://eips.ethereum.org/EIPS/eip-7723#considered-for-inclusion)). ### Specification + Testing Status From 98f3158d911bd33d5dddbcdb00d470d98e545ef6 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Mon, 8 Dec 2025 18:04:54 +0000 Subject: [PATCH 10/11] Review comments --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 9b328e50ac..05c1b3979b 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -58,6 +58,20 @@ body: - [ ] Add the issue to the target fork milestone if applicable (i.e., the EIP is at least in the [CFI stage](https://eips.ethereum.org/EIPS/eip-7723#considered-for-inclusion)). + #### Guidance for Marking Items Complete + + An item should only be checked off once the EIP is considered *stable*. In this context, stable means: + + - No major issues or ambiguities are still being uncovered in the specification or tests. + - There are no open discussion points awaiting resolution. + - Client implementations have been consistently passing the tests for at least a week. + + It is ultimately up to the owners' discretion to decide when an item should be marked as complete, using this guidance as the basis for that decision. + + In exceptional cases, an EIP may require changes after some items have been marked complete or even after the entire issue has been completed and closed. This can happen, for example, when significant design optimizations are identified and agreed upon in ACD, or when critical security issues surface and require updates to the specification or tests. + + When this occurs, owners should either unmark the relevant checkboxes if the issue is still open, or create a new tracking issue for the modifications if the original issue had already been closed. + ### Specification + Testing Status - [ ] Testing complexity assessed and documented. @@ -67,10 +81,10 @@ body: - [ ] Required testing framework modifications implemented. - [ ] Test suite implemented. - [ ] Full code coverage for all changes. - - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete. - [ ] No regressions or failures in tests from prior forks (including static tests). + - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete. - [ ] Hardening session completed. - - [ ] Benchmarking performed and results documented. + - [ ] Benchmarking tests written and results documented. - [ ] Ran tests using `execute` to ensure compatibility, and marked specific tests to be skipped when they cannot be executed on live networks. - [ ] Added Mainnet-marked tests ([example test](https://github.com/ethereum/execution-specs/blob/2a6f9ee98ba7c0d04c7d523a0ea0ee8a98a5c418/tests/osaka/eip7939_count_leading_zeros/test_eip_mainnet.py)). @@ -78,4 +92,3 @@ body: - [ ] Hive tests passing on all implementations. - [ ] EIP included in a devnet. - \ No newline at end of file From 835f449664d5486b9b855f0d17cfbc73fff807a5 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Mon, 8 Dec 2025 19:14:45 +0100 Subject: [PATCH 11/11] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 05c1b3979b..8f745ec5d9 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -90,5 +90,5 @@ body: ### Process Status - - [ ] Hive tests passing on all implementations. + - [ ] Hive tests passing on at least two implementations. - [ ] EIP included in a devnet.