fix: add Makefile command; move ExporterOptions to shared type

Author: filinvadim

Makefile

@@ -20,6 +20,7 @@ VERSION ?= "$(shell git describe --tags --abbrev=0 | cut -c2-)"
 COMMIT_HASH ?= "$(shell git describe --long --dirty --always --match "" || true)"
 CLEAN_COMMIT ?= "$(shell git describe --long --always --match "" || true)"
 COMMIT_TIME ?= "$(shell git show -s --format=%ct $(CLEAN_COMMIT) || true)"
+BUILD_TAGS ?=
 LDFLAGS ?= -s -w \
 -X github.com/ethersphere/bee/v2.version="$(VERSION)" \
 -X github.com/ethersphere/bee/v2.commitHash="$(COMMIT_HASH)" \
@@ -31,11 +32,14 @@ LDFLAGS ?= -s -w \
 .PHONY: all
 all: build lint test-race binary
 
-.PHONY: binary
+.PHONY: binary binary-nometrics
 binary: export CGO_ENABLED=0
 binary: dist FORCE
 	$(GO) version
-	$(GO) build -trimpath -ldflags "$(LDFLAGS)" -o dist/bee ./cmd/bee
+	$(GO) build -trimpath -ldflags "$(LDFLAGS)" -tags "$(BUILD_TAGS)" -o dist/bee ./cmd/bee
+
+binary-nometrics:
+	$(MAKE) binary BUILD_TAGS=nometrics
 
 dist:
 	mkdir $@

pkg/metrics/exporter/exporter.go

@@ -2,27 +2,16 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+//go:build !nometrics
+// +build !nometrics
+
 package exporter
 
 import (
 	exporter "contrib.go.opencensus.io/exporter/prometheus"
 	"github.com/prometheus/client_golang/prometheus"
 )
 
-type MetricsSourcer interface {
-	MustRegister(...prometheus.Collector)
-	Register(prometheus.Collector) error
-	Unregister(prometheus.Collector) bool
-}
-
-// The goroutine leak `go.opencensus.io/stats/view.(*worker).start` appears solely because of
-// importing the `exporter.Options` type from `go.opencensus.io` package
-// (either directly or transitively).
-type ExporterOptions struct {
-	Namespace string
-	Registry  MetricsSourcer
-}
-
 func NewExporter(o ExporterOptions) error {
 	r, _ := o.Registry.(*prometheus.Registry)
 	opts := exporter.Options{

pkg/metrics/exporter/noop.go

@@ -0,0 +1,12 @@
+// Copyright 2020 The Swarm Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build nometrics
+// +build nometrics
+
+package exporter
+
+func NewExporter(o ExporterOptions) error {
+	return nil
+}

pkg/metrics/exporter/types.go

@@ -0,0 +1,20 @@
+// Copyright 2020 The Swarm Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package exporter
+
+import (
+	"github.com/prometheus/client_golang/prometheus"
+)
+
+type MetricsSourcer interface {
+	MustRegister(...prometheus.Collector)
+	Register(prometheus.Collector) error
+	Unregister(prometheus.Collector) bool
+}
+
+type ExporterOptions struct {
+	Namespace string
+	Registry  MetricsSourcer
+}

pkg/metrics/noop.go

@@ -144,10 +144,6 @@ func NewRegistry() MetricsRegistererGatherer {
 	return &registryNoop{}
 }
 
-func NewExporter(o ExporterOptions) error {
-	return nil
-}
-
 func MustRegister(_ ...Collector) {
 	// pass
 }