Skip to content

toWei: incorrect result for small numbers (< 1e-6) #6

@slavafomin

Description

@slavafomin

Issue Type

Description

The toWei() function will return incorrect results when passing numbers smaller than 1e-6 to it.

For example toWei(1e-7, 'gwei').toString() will return 2377000000000 instead of 100.

The issue starts here and then cascades downward. The problem is that you are using the String constructor to convert number to a string. However, it will produce some small numbers in exponential notation instead of the fixed notation that you are expecting.

Steps to reproduce

Check the PR #7.

Versions

Doesn't matter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions