Skip to content

Commit 18897e3

Browse files
committed
Revert "Provide possibility to pass GITHUB_TOKEN to check workflow"
This reverts commit 3d0f7b6.
1 parent 3d0f7b6 commit 18897e3

File tree

3 files changed

+33
-75
lines changed

3 files changed

+33
-75
lines changed

.github/workflows/checks.yml

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
name: Checks
22

3-
on:
4-
workflow_call:
5-
secrets:
6-
GITHUB_TOKEN:
7-
required: false
3+
on: workflow_call
84

95
jobs:
106

@@ -26,28 +22,28 @@ jobs:
2622

2723
build-documentation-job:
2824
name: Build Documentation
29-
needs: [ version-check-job ]
25+
needs: [version-check-job]
3026
runs-on: ubuntu-latest
3127

3228
steps:
33-
- name: SCM Checkout
34-
uses: actions/checkout@v3
29+
- name: SCM Checkout
30+
uses: actions/checkout@v3
3531

36-
- name: Setup Python & Poetry Environment
37-
uses: exasol/python-toolbox/.github/actions/python-environment@main
32+
- name: Setup Python & Poetry Environment
33+
uses: exasol/python-toolbox/.github/actions/python-environment@main
3834

39-
- name: Build Documentation
40-
run: |
41-
poetry run python -m nox -s build-docs
35+
- name: Build Documentation
36+
run: |
37+
poetry run python -m nox -s build-docs
4238
4339
lint-job:
4440
name: Linting (Python-${{ matrix.python-version }})
45-
needs: [ version-check-job ]
41+
needs: [version-check-job]
4642
runs-on: ubuntu-latest
4743
strategy:
4844
fail-fast: false
4945
matrix:
50-
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
46+
python-version: ["3.8", "3.9", "3.10", "3.11"]
5147

5248
steps:
5349
- name: SCM Checkout
@@ -63,12 +59,12 @@ jobs:
6359

6460
type-check-job:
6561
name: Type Checking (Python-${{ matrix.python-version }})
66-
needs: [ version-check-job ]
62+
needs: [version-check-job]
6763
runs-on: ubuntu-latest
6864
strategy:
6965
fail-fast: false
7066
matrix:
71-
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
67+
python-version: ["3.8", "3.9", "3.10", "3.11"]
7268

7369
steps:
7470
- name: SCM Checkout
@@ -84,13 +80,13 @@ jobs:
8480

8581
tests-job:
8682
name: Tests (Python-${{ matrix.python-version }}, Exasol-${{ matrix.exasol-version}})
87-
needs: [ build-documentation-job, lint-job, type-check-job ]
83+
needs: [build-documentation-job, lint-job, type-check-job]
8884
runs-on: ubuntu-latest
8985
strategy:
9086
fail-fast: false
9187
matrix:
92-
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
93-
exasol-version: [ "7.1.9" ]
88+
python-version: ["3.8", "3.9", "3.10", "3.11"]
89+
exasol-version: ["7.1.9"]
9490

9591
steps:
9692
- name: SCM Checkout

changelog.d/20230118_082710_nicola.coretti.rst

Lines changed: 0 additions & 34 deletions
This file was deleted.

exasol/toolbox/templates/.github/workflows/checks.yml

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
name: Checks
22

3-
on:
4-
workflow_call:
5-
secrets:
6-
GITHUB_TOKEN:
7-
required: false
3+
on: workflow_call
84

95
jobs:
106

@@ -22,32 +18,32 @@ jobs:
2218
uses: exasol/python-toolbox/.github/actions/python-environment@main
2319

2420
- name: Check Version(s)
25-
run: poetry run version-check `poetry run python -c "from noxconfig import PROJECT_CONFIG; print(PROJECT_CONFIG.version_file)"`
21+
run: poetry run version-check exasol/toolbox/version.py
2622

2723
build-documentation-job:
2824
name: Build Documentation
29-
needs: [ version-check-job ]
25+
needs: [version-check-job]
3026
runs-on: ubuntu-latest
3127

3228
steps:
33-
- name: SCM Checkout
34-
uses: actions/checkout@v3
29+
- name: SCM Checkout
30+
uses: actions/checkout@v3
3531

36-
- name: Setup Python & Poetry Environment
37-
uses: exasol/python-toolbox/.github/actions/python-environment@main
32+
- name: Setup Python & Poetry Environment
33+
uses: exasol/python-toolbox/.github/actions/python-environment@main
3834

39-
- name: Build Documentation
40-
run: |
41-
poetry run python -m nox -s build-docs
35+
- name: Build Documentation
36+
run: |
37+
poetry run python -m nox -s build-docs
4238
4339
lint-job:
4440
name: Linting (Python-${{ matrix.python-version }})
45-
needs: [ version-check-job ]
41+
needs: [version-check-job]
4642
runs-on: ubuntu-latest
4743
strategy:
4844
fail-fast: false
4945
matrix:
50-
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
46+
python-version: ["3.8", "3.9", "3.10", "3.11"]
5147

5248
steps:
5349
- name: SCM Checkout
@@ -63,12 +59,12 @@ jobs:
6359

6460
type-check-job:
6561
name: Type Checking (Python-${{ matrix.python-version }})
66-
needs: [ version-check-job ]
62+
needs: [version-check-job]
6763
runs-on: ubuntu-latest
6864
strategy:
6965
fail-fast: false
7066
matrix:
71-
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
67+
python-version: ["3.8", "3.9", "3.10", "3.11"]
7268

7369
steps:
7470
- name: SCM Checkout
@@ -84,13 +80,13 @@ jobs:
8480

8581
tests-job:
8682
name: Tests (Python-${{ matrix.python-version }}, Exasol-${{ matrix.exasol-version}})
87-
needs: [ build-documentation-job, lint-job, type-check-job ]
83+
needs: [build-documentation-job, lint-job, type-check-job]
8884
runs-on: ubuntu-latest
8985
strategy:
9086
fail-fast: false
9187
matrix:
92-
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
93-
exasol-version: [ "7.1.9" ]
88+
python-version: ["3.8", "3.9", "3.10", "3.11"]
89+
exasol-version: ["7.1.9"]
9490

9591
steps:
9692
- name: SCM Checkout

0 commit comments

Comments
 (0)