LogLevels solution accused of hardcoding test data

[divBad98]

I wrote the following code for LogLevels:

`public class LogLevels {

public static String message(String logLine) {
    int colonIdx = logLine.indexOf(":");
    return logLine.substring(colonIdx + 1).trim();
}

public static String logLevel(String logLine) {
    if (logLine.contains("INFO")) {
        return "info";
    } else if (logLine.contains("WARNING")) {
        return "warning";
    } else {
        return "error";
    }
}

public static String reformat(String logLine) {
    return message(logLine) + " (" + logLevel(logLine) + ")";
}

}
`

However, the editor keeps saying that I've hardcoded test data. I think it might be because of the specific log level strings that I'm looking for, but what's wrong with that?

[kahgoh]

Well, consider the log message [ERROR]: This is not an INFO message. What will logLevel return?

[divBad98]

I see what you mean. I tried to change my code so that it checks for [INFO] or [WARNING], but I got the same error.

[kahgoh]

Did you mean you updated your solution to look specifically [INFO] (e.g. you now have if (logLine.contains("[INFO]")))? That's not going to work if the message becomes [ERROR]: This is not an [INFO] message...

Well, the other reason is that looking specifically the INFO, WARNING and ERROR strings also means it would recognize only those levels. What if we were to add other levels? ...

[divBad98]

We are told to look for those levels specifically. Additionally, even the hints specify that we need to look for hardcoded strings, and while you make a point about your example message, even using the "startsWith()" method instead of "contains()" hasn't gotten rid of this error. Even if we used enums, I'm not sure how that would fix the issue.

[aedrianescultura]

The ideal solution requires one not using the mentioned log levels in the exercise. You may consider extracting the log level enclosed in the square brackets (and before the first colon).