diff --git a/lib/index.js b/lib/index.js index ad899ca..f89316b 100644 --- a/lib/index.js +++ b/lib/index.js @@ -1,5 +1,4 @@ (function () { - 'use strict'; var assign = require('object-assign'); @@ -45,15 +44,12 @@ value: '*' }]); } else if (isString(options.origin)) { - // fixed origin + // fixed origin: response is always the same regardless of request Origin, + // so Vary: Origin must NOT be set (per fetch spec, see issue #332) headers.push([{ key: 'Access-Control-Allow-Origin', value: options.origin }]); - headers.push([{ - key: 'Vary', - value: 'Origin' - }]); } else { isAllowed = isOriginAllowed(requestOrigin, options.origin); // reflect origin @@ -66,7 +62,6 @@ value: 'Origin' }]); } - return headers; } @@ -94,7 +89,6 @@ function configureAllowedHeaders(options, req) { var allowedHeaders = options.allowedHeaders || options.headers; var headers = []; - if (!allowedHeaders) { allowedHeaders = req.headers['access-control-request-headers']; // .headers wasn't specified, so reflect the request headers headers.push([{ @@ -110,7 +104,6 @@ value: allowedHeaders }]); } - return headers; }