Commit 0874746
Fix remaining missing debugger build flags for open source builds (#54774)
Summary:
Pull Request resolved: #54774
NOTE: This diff is a backport of #54770, where on the `0.83-stable` release branch, Network support for React Native DevTools was in a broken state under the open source build systems.
### Cause
Network debugging support depends a number of `REACT_NATIVE_DEBUGGER_ENABLED` preprocessor flags, which we use to compile away any overhead in production builds.
As we unfortunately use a total of **4 native build systems** today (with Buck 2 internally and primarily), the registration of these flags was missing across a number of native ObjC/C++ packages, which are now fixed with this PR.
- D87864636 aimed to address this as we weren't seeing the Network panel at all. However, it was insufficient, as it has only partially enabled network features between platforms.
### This diff
Add missing preprocessor flags in:
- Android:
- `src/main/jni/react/devsupport/CMakeLists.txt`
- `src/main/jni/CMakeLists.txt`
- iOS (Pods):
- `React-jsinspectorNetwork`
- iOS (`Package.swift`):
- `Libraries/Network`
Changelog: [Internal]
Reviewed By: vzaidman
Differential Revision: D88284345
fbshipit-source-id: 8ff0b424834b40ed186432f630287abe5fe8b9971 parent 3084224 commit 0874746
File tree
4 files changed
+21
-1
lines changed- packages/react-native
- ReactAndroid/src/main/jni
- react/devsupport
- scripts/cocoapods
4 files changed
+21
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
593 | 593 | | |
594 | 594 | | |
595 | 595 | | |
596 | | - | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
597 | 601 | | |
598 | 602 | | |
599 | 603 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| 65 | + | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
| |||
0 commit comments