Skip to content

Commit 9857f48

Browse files
committed
OS (Linux): actually display debian .x version
Also display code name on Linux
1 parent 2899763 commit 9857f48

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/detection/os/os_linux.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,9 @@ static void getDebianVersion(FFOSResult* result)
126126
{
127127
FF_STRBUF_AUTO_DESTROY debianVersion = ffStrbufCreate();
128128
ffAppendFileBuffer("/etc/debian_version", &debianVersion);
129-
if (debianVersion.length)
130-
ffStrbufSet(&result->version, &debianVersion);
129+
if (!debianVersion.length) return;
130+
ffStrbufSet(&result->version, &debianVersion);
131+
ffStrbufSet(&result->versionID, &debianVersion);
131132
}
132133

133134
static void detectOS(FFOSResult* os)

src/modules/os/os.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,20 @@ static void buildOutputDefault(const FFOSResult* os, FFstrbuf* result)
2121
else
2222
ffStrbufAppend(result, &instance.state.platform.systemName);
2323

24-
#ifdef __APPLE__
25-
if(os->codename.length > 0)
24+
//Append code name if it is missing
25+
if(os->codename.length > 0 && !ffStrbufContain(result, &os->versionID))
2626
{
2727
ffStrbufAppendC(result, ' ');
2828
ffStrbufAppend(result, &os->codename);
2929
}
30-
#endif
3130

3231
//Append version if it is missing
33-
if(os->versionID.length > 0 && ffStrbufFirstIndex(result, &os->versionID) == result->length)
32+
if(os->versionID.length > 0 && !ffStrbufContain(result, &os->versionID))
3433
{
3534
ffStrbufAppendC(result, ' ');
3635
ffStrbufAppend(result, &os->versionID);
3736
}
38-
else if(os->versionID.length == 0 && os->version.length > 0 && ffStrbufFirstIndex(result, &os->version) == result->length)
37+
else if(os->versionID.length == 0 && os->version.length > 0 && !ffStrbufContain(result, &os->version))
3938
{
4039
ffStrbufAppendC(result, ' ');
4140
ffStrbufAppend(result, &os->version);

0 commit comments

Comments
 (0)