From bdf515c88b6e14fbe0025950983ace34ce855e4b Mon Sep 17 00:00:00 2001
From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Date: Mon, 19 Jan 2026 13:51:53 +0000
Subject: [PATCH] fix: add explicit FS deletion in deleteSessionCascade

Instead of relying on orphan cleanup to eventually delete session folders,
explicitly delete the session folder after removing from TinyBase.

This fixes the root cause of orphan accumulation by making deletion
explicit rather than relying on eventual cleanup.

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
---
 .../src/store/tinybase/store/deleteSession.ts | 72 ++++++++++---------
 1 file changed, 37 insertions(+), 35 deletions(-)

diff --git a/apps/desktop/src/store/tinybase/store/deleteSession.ts b/apps/desktop/src/store/tinybase/store/deleteSession.ts
index 823ce60dde..a386fc8a12 100644
--- a/apps/desktop/src/store/tinybase/store/deleteSession.ts
+++ b/apps/desktop/src/store/tinybase/store/deleteSession.ts
@@ -25,47 +25,49 @@ export async function deleteSessionCascade(
   indexes: ReturnType<typeof main.UI.useIndexes>,
   sessionId: string,
 ): Promise<void> {
-  await fsSyncCommands.audioDelete(sessionId);
-
+  // Delete from TinyBase first
   if (!indexes) {
     store.delRow("sessions", sessionId);
-    return;
-  }
+  } else {
+    store.transaction(() => {
+      const transcriptIds = indexes.getSliceRowIds(
+        main.INDEXES.transcriptBySession,
+        sessionId,
+      );
 
-  store.transaction(() => {
-    const transcriptIds = indexes.getSliceRowIds(
-      main.INDEXES.transcriptBySession,
-      sessionId,
-    );
+      for (const transcriptId of transcriptIds) {
+        store.delRow("transcripts", transcriptId);
+      }
 
-    for (const transcriptId of transcriptIds) {
-      store.delRow("transcripts", transcriptId);
-    }
+      deleteByIndex(
+        store,
+        indexes,
+        main.INDEXES.sessionParticipantsBySession,
+        sessionId,
+        "mapping_session_participant",
+      );
+      deleteByIndex(
+        store,
+        indexes,
+        main.INDEXES.tagSessionsBySession,
+        sessionId,
+        "mapping_tag_session",
+      );
+      deleteByIndex(
+        store,
+        indexes,
+        main.INDEXES.enhancedNotesBySession,
+        sessionId,
+        "enhanced_notes",
+      );
 
-    deleteByIndex(
-      store,
-      indexes,
-      main.INDEXES.sessionParticipantsBySession,
-      sessionId,
-      "mapping_session_participant",
-    );
-    deleteByIndex(
-      store,
-      indexes,
-      main.INDEXES.tagSessionsBySession,
-      sessionId,
-      "mapping_tag_session",
-    );
-    deleteByIndex(
-      store,
-      indexes,
-      main.INDEXES.enhancedNotesBySession,
-      sessionId,
-      "enhanced_notes",
-    );
+      store.delRow("sessions", sessionId);
+    });
+  }
 
-    store.delRow("sessions", sessionId);
-  });
+  // Explicitly delete the session folder from filesystem
+  // This replaces reliance on orphan cleanup for session deletion
+  await fsSyncCommands.deleteSessionFolder(sessionId);
 }
 
 export function useDeleteSession() {