Merge branch 'development' into feature/ExtractLocalVariable_improvements

Author: SlavaRa

External/Plugins/CodeRefactor/PluginMain.cs

@@ -379,33 +379,38 @@ private void UpdateMenuItems()
                 refactorContextMenu.MoveMenuItem.Enabled = false;
                 this.surroundContextMenu.Enabled = false;
                 this.refactorMainMenu.SurroundMenu.Enabled = false;
-                this.refactorContextMenu.ExtractMethodMenuItem.Enabled = false;
-                this.refactorContextMenu.ExtractLocalVariableMenuItem.Enabled = false;
                 this.refactorMainMenu.ExtractMethodMenuItem.Enabled = false;
+                this.refactorContextMenu.ExtractMethodMenuItem.Enabled = false;
                 this.refactorMainMenu.ExtractLocalVariableMenuItem.Enabled = false;
+                this.refactorContextMenu.ExtractLocalVariableMenuItem.Enabled = false;
                 ITabbedDocument document = PluginBase.MainForm.CurrentDocument;
                 if (document != null && document.IsEditable && langIsValid)
                 {
                     bool isValidFile = IsValidFile(document.FileName);
                     refactorMainMenu.MoveMenuItem.Enabled = isValidFile;
                     refactorContextMenu.MoveMenuItem.Enabled = isValidFile;
-                    if (document.SciControl.SelTextSize > 1)
+                    var sci = document.SciControl;
+                    if (sci.SelTextSize > 0)
                     {
-                        Int32 selEnd = document.SciControl.SelectionEnd;
-                        Int32 selStart = document.SciControl.SelectionStart;
-                        if (!document.SciControl.PositionIsOnComment(selEnd) || !document.SciControl.PositionIsOnComment(selStart))
+                        if (!sci.PositionIsOnComment(sci.SelectionStart) || !sci.PositionIsOnComment(sci.SelectionEnd))
                         {
                             this.surroundContextMenu.Enabled = true;
                             this.refactorMainMenu.SurroundMenu.Enabled = true;
-                            this.refactorContextMenu.ExtractMethodMenuItem.Enabled = true;
                             this.refactorMainMenu.ExtractMethodMenuItem.Enabled = true;
-                            this.refactorContextMenu.ExtractLocalVariableMenuItem.Enabled = true;
+                            this.refactorContextMenu.ExtractMethodMenuItem.Enabled = true;
+                        }
+                        var declAtSelStart = context.GetDeclarationAtLine(sci.LineFromPosition(sci.SelectionStart));
+                        var declAtSelEnd = context.GetDeclarationAtLine(sci.LineFromPosition(sci.SelectionEnd));
+                        if (declAtSelStart != null && declAtSelStart.Member != null && (declAtSelStart.Member.Flags & FlagType.Function) > 0
+                            && declAtSelEnd != null && declAtSelStart.Member.Equals(declAtSelEnd.Member))
+                        {
                             this.refactorMainMenu.ExtractLocalVariableMenuItem.Enabled = true;
+                            this.refactorContextMenu.ExtractLocalVariableMenuItem.Enabled = true;
                         }
                     }
                 }
-                this.refactorContextMenu.CodeGeneratorMenuItem.Enabled = isValid;
                 this.refactorMainMenu.CodeGeneratorMenuItem.Enabled = isValid;
+                this.refactorContextMenu.CodeGeneratorMenuItem.Enabled = isValid;
             }
             catch {}
         }

External/Plugins/DataEncoder/PluginMain.cs

@@ -192,7 +192,7 @@ public String LoadBinaryFile(String file)
                 Object settings = new Object();
                 MemoryStream stream = new MemoryStream();
                 settings = ObjectSerializer.Deserialize(file, settings, false);
-                XmlSerializer xs = new XmlSerializer(settings.GetType());
+                XmlSerializer xs = XmlSerializer.FromTypes(new[]{settings.GetType()})[0];
                 xs.Serialize(stream, settings); // Obj -> XML
                 XmlTextWriter xw = new XmlTextWriter(stream, Encoding.UTF8);
                 xw.Formatting = Formatting.Indented; stream.Close();
@@ -217,7 +217,7 @@ public void SaveBinaryFile(String file, String text)
                 Byte[] buffer = Encoding.UTF8.GetBytes(text);
                 MemoryStream stream = new MemoryStream(buffer);
                 TypeData typeData = this.GetFileObjectType(file);
-                XmlSerializer xs = new XmlSerializer(typeData.Type);
+                XmlSerializer xs = XmlSerializer.FromTypes(new[]{typeData.Type})[0];
                 settings = xs.Deserialize(stream); // XML -> Obj
                 ObjectSerializer.Serialize(file, settings);
                 stream.Close();

External/Plugins/FlashDebugger/Utilities.cs

@@ -9,15 +9,15 @@ public class SerializeXML<T>
         {
             public static void SaveFile(string filename, T obj)
             {
-                XmlSerializer serializer1 = new XmlSerializer(typeof(T));
+                XmlSerializer serializer1 = XmlSerializer.FromTypes(new[]{typeof(T)})[0];
                 FileStream fs1 = new FileStream(filename, FileMode.Create);
                 serializer1.Serialize(fs1, obj);
                 fs1.Close();
             }
 
             public static T LoadFile(string filename)
             {
-                XmlSerializer serializer2 = new XmlSerializer(typeof(T));
+                XmlSerializer serializer2 = XmlSerializer.FromTypes(new[]{typeof(T)})[0];
                 FileStream fs2 = new FileStream(filename, FileMode.Open);
                 T loadClasses = (T)serializer2.Deserialize(fs2);
                 fs2.Close();
@@ -26,7 +26,7 @@ public static T LoadFile(string filename)
 
             public static T LoadString(string s)
             {
-                XmlSerializer serializer = new XmlSerializer(typeof(T));
+                XmlSerializer serializer = XmlSerializer.FromTypes(new[]{typeof(T)})[0];
                 StringReader str = new StringReader(s);
                 T loadClasses = (T)serializer.Deserialize(str);
                 str.Close();

External/Plugins/StartPage/ProjectInfo/RecentProjectList.cs

@@ -11,7 +11,7 @@ public class RecentProjectList : List<RecentProject>
 
         public RecentProjectList()
         {
-            this.xmlSerializer = new XmlSerializer(this.GetType());
+            this.xmlSerializer = XmlSerializer.FromTypes(new[]{this.GetType()})[0];
         }
         public RecentProjectList(List<String> recentProjects)
         {

PluginCore/ScintillaNet/Configuration/ConfigurationUtility.cs

@@ -47,7 +47,7 @@ protected virtual Stream OpenFile(string filename, ConfigFile parent)
 
         protected object Deserialize(TextReader reader, Type aType)
         {
-            XmlSerializer xmlSerializer = new XmlSerializer(aType);
+            XmlSerializer xmlSerializer = XmlSerializer.FromTypes(new[]{aType})[0];
             object local = xmlSerializer.Deserialize(reader);
             reader.Close();
             return local;