feat: add ci/cd pipelines for releases #268
Conversation
|
AI pull requests... Yay. |
|
Holy AI |
|
The commit looks AI too 😭 |
|
What issue does this PR solve? |
There was a problem hiding this comment.
yk seems good and stuff, but how about you do something yourself without AI?
There was a problem hiding this comment.
No need to be rude and have no need to tell you my whole CV, anyways, addressed all of the points above.
^ |
I believe it's for the 'Download' section on the website. @misterquestions is this PR ready to be merged? |
ReCore-sys
left a comment
ReCore-sys
left a comment
There was a problem hiding this comment.
Needs some changes, as others have said it's pretty clearly AI generated so can you please double check the output it gives you.
| if: matrix.cross | ||
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: cross |
There was a problem hiding this comment.
Why are we using cross? Can't we just use multiple runners and compile natively?
| - name: Build release binary | ||
| run: | | ||
| if [ "${{ matrix.cross }}" = "true" ]; then | ||
| cross build --release --target ${{ matrix.target }} |
There was a problem hiding this comment.
Why are we using cross? It's already doing all this on native runners?
| ``` | ||
| ## What's Changed | ||
| <!-- Add your changelog here --> |
There was a problem hiding this comment.
Is there meant to be a changelog here or did you not see chatgpt asking you to put in your changelog. Also this doesn't make much sense, it's automatically generated, no?
| id: notes | ||
| run: | | ||
| cat > release_notes.md << 'EOF' | ||
| ## Installation |
There was a problem hiding this comment.
This isn't really relevant to releases since the process will be the same for each one, this should just be in the readme
| name: Release ${{ inputs.version }} | ||
| body_path: ${{ steps.notes.outputs.notes_file }} | ||
| draft: false | ||
| prerelease: false |
There was a problem hiding this comment.
This should be configurable, would be annoying to have this entire workflow setup and then still have to do it manually for pre-releases
|
I'm hesitant to merge, with the number of problems that you've already had to fix I'd be worried about issues that no-one has caught yet |
|
@misterquestions any news? |
6 participants
CI/CD Pipeline for Releases
Overview
This PR introduces a complete CI/CD pipeline for automated testing, building, and releasing FerrumC across multiple platforms, with automatic deployment integration to the website.
Changes
🔄 Refactored CI Workflow (
ci.yml)cross🚀 New Release Workflow (
release.yml)workflow_dispatchwith required approval gate via GitHub environmentsghcr.io)🐳 Docker Improvements
latest🔗 Integration with Site Repository
Benefits