Skip to content

Commit f6a471f

Browse files
dmason30StyleCIBot
andauthored
Update to Laravel Dashboard 3.x and Chart Tile 6.x (#15)
* Update to Laravel Dashboard 3.x and Chart Tile 6.x * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
1 parent 8776e91 commit f6a471f

File tree

7 files changed

+94
-166
lines changed

7 files changed

+94
-166
lines changed

.github/workflows/run-tests.yml

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,10 @@ jobs:
99
fail-fast: true
1010
matrix:
1111
os: [ubuntu-latest]
12-
php: ['8.3', '8.2', '8.1', '8.0', '7.4']
13-
laravel: [10.*, 9.*, 8.*]
12+
php: ['8.3', '8.2', '8.1']
13+
laravel: [10.*]
1414
dependency-version: [prefer-lowest, prefer-stable]
15-
exclude:
16-
- laravel: 9.*
17-
php: '7.4'
18-
- laravel: 10.*
19-
php: '7.4'
20-
- laravel: 10.*
21-
php: '8.0'
2215
include:
23-
- laravel: 8.*
24-
testbench: ^6.23
25-
- laravel: 9.*
26-
testbench: ^7.0
2716
- laravel: 10.*
2817
testbench: ^8.0
2918

composer.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,14 @@
1818
}
1919
],
2020
"require": {
21-
"php": "^7.4|^8.0",
22-
"fidum/laravel-dashboard-chart-tile": "^5.0.1",
23-
"laravel/vapor-cli": "^1.54",
24-
"spatie/laravel-dashboard": "^2.1.4"
21+
"php": "^8.1",
22+
"fidum/laravel-dashboard-chart-tile": "^6.0",
23+
"laravel/vapor-cli": "^1.60",
24+
"spatie/laravel-dashboard": "^3.0"
2525
},
2626
"require-dev": {
2727
"mockery/mockery": "^1.5",
28-
"nunomaduro/laravel-mojito": "^0.2.10",
29-
"orchestra/testbench": "^6.0|^7.0|^8.0",
28+
"orchestra/testbench": "^8.0",
3029
"phpunit/phpunit": "^9.5"
3130
},
3231
"autoload": {

tests/TestCase.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use Fidum\ChartTile\ChartTileServiceProvider;
77
use Fidum\VaporMetricsTile\VaporMetricsTileServiceProvider;
88
use Livewire\LivewireServiceProvider;
9-
use NunoMaduro\LaravelMojito\MojitoServiceProvider;
109
use Orchestra\Testbench\TestCase as BaseTestCase;
1110
use Spatie\Dashboard\DashboardServiceProvider;
1211

@@ -72,7 +71,6 @@ protected function getPackageProviders($app): array
7271
ChartTileServiceProvider::class,
7372
DashboardServiceProvider::class,
7473
LivewireServiceProvider::class,
75-
MojitoServiceProvider::class,
7674
VaporMetricsTileServiceProvider::class,
7775
];
7876
}

tests/Unit/Components/VaporCacheMetricsComponentTest.php

Lines changed: 33 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -7,40 +7,31 @@
77
use Fidum\VaporMetricsTile\Tests\TestCase;
88
use Fidum\VaporMetricsTile\VaporMetricsClient;
99
use Livewire\Livewire;
10-
use Livewire\Testing\TestableLivewire;
11-
use NunoMaduro\LaravelMojito\ViewAssertion;
1210

1311
class VaporCacheMetricsComponentTest extends TestCase
1412
{
1513
public function testMount()
1614
{
17-
$component = new VaporCacheMetricsComponent('');
18-
$component->mount('a1:a2', 'My Cache Defaults');
19-
20-
$this->assertSame($component->position, 'a1:a2');
21-
$this->assertSame($component->tileName, 'My Cache Defaults');
15+
Livewire::test(VaporCacheMetricsComponent::class, [
16+
'position' => 'a1:a2',
17+
'tileName' => 'My Cache Defaults',
18+
])
19+
->assertSet('position', 'a1:a2')
20+
->assertSet('tileName', 'My Cache Defaults');
2221
}
2322

2423
public function testRenderNoResults()
2524
{
26-
/** @var TestableLivewire $result */
27-
$result = Livewire::test(VaporCacheMetricsComponent::class)
25+
Livewire::test(VaporCacheMetricsComponent::class)
2826
->set('position', 'a1:a2')
2927
->set('tileName', 'My Cache Changed')
30-
->call('render');
31-
32-
$html = $result->lastRenderedDom;
33-
34-
$result->assertSee('My Cache Changed')
35-
->assertViewHas('refreshIntervalInSeconds', 60);
36-
37-
$this->assertStringNotContainsString('Node 1', $html);
38-
$this->assertStringNotContainsString('Node 2', $html);
39-
40-
(new ViewAssertion($html))
41-
->contains('0% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
42-
->contains('0 <span class="text-dimmed text-xs">Cache Hits</span>')
43-
->contains('0 <span class="text-dimmed text-xs">Cache Misses</span>');
28+
->assertSee('My Cache Changed')
29+
->assertViewHas('refreshIntervalInSeconds', 60)
30+
->assertDontSee('Node 1')
31+
->assertDontSee('Node 2')
32+
->assertSeeHtml('0% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
33+
->assertSeeHtml('0 <span class="text-dimmed text-xs">Cache Hits</span>')
34+
->assertSeeHtml('0 <span class="text-dimmed text-xs">Cache Misses</span>');
4435
}
4536

4637
public function testRenderSingleNode()
@@ -51,24 +42,16 @@ public function testRenderSingleNode()
5142
'totalCacheMisses' => [13243],
5243
]);
5344

54-
/** @var TestableLivewire $result */
55-
$result = Livewire::test(VaporCacheMetricsComponent::class)
45+
Livewire::test(VaporCacheMetricsComponent::class)
5646
->set('position', 'a1:a2')
5747
->set('tileName', 'My Cache Defaults')
58-
->call('render');
59-
60-
$html = $result->lastRenderedDom;
61-
62-
$result->assertSee('My Cache Defaults')
63-
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS);
64-
65-
$this->assertStringNotContainsString('Node 1', $html);
66-
$this->assertStringNotContainsString('Node 2', $html);
67-
68-
(new ViewAssertion($html))
69-
->contains('43% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
70-
->contains('1,123 <span class="text-dimmed text-xs">Cache Hits</span>')
71-
->contains('13,243 <span class="text-dimmed text-xs">Cache Misses</span>');
48+
->assertSee('My Cache Defaults')
49+
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS)
50+
->assertDontSee('Node 1')
51+
->assertDontSee('Node 2')
52+
->assertSeeHtml('43% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
53+
->assertSeeHtml('1,123 <span class="text-dimmed text-xs">Cache Hits</span>')
54+
->assertSeeHtml('13,243 <span class="text-dimmed text-xs">Cache Misses</span>');
7255
}
7356

7457
public function testRenderMultipleNodes()
@@ -79,25 +62,18 @@ public function testRenderMultipleNodes()
7962
'totalCacheMisses' => [13243, 6654],
8063
]);
8164

82-
/** @var TestableLivewire $result */
83-
$result = Livewire::test(VaporCacheMetricsComponent::class)
65+
Livewire::test(VaporCacheMetricsComponent::class)
8466
->set('position', 'a1:a2')
8567
->set('tileName', 'My Cache Defaults')
86-
->call('render');
87-
88-
$result->assertSee('My Cache Defaults')
89-
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS);
90-
91-
$assert = new ViewAssertion($result->lastRenderedDom);
92-
93-
$assert->contains('Node 1')
94-
->contains('43% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
95-
->contains('1,123 <span class="text-dimmed text-xs">Cache Hits</span>')
96-
->contains('13,243 <span class="text-dimmed text-xs">Cache Misses</span>');
97-
98-
$assert->contains('Node 2')
99-
->contains('75% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
100-
->contains('6,678 <span class="text-dimmed text-xs">Cache Hits</span>')
101-
->contains('6,654 <span class="text-dimmed text-xs">Cache Misses</span>');
68+
->assertSee('My Cache Defaults')
69+
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS)
70+
->assertSeeHtml('Node 1')
71+
->assertSeeHtml('43% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
72+
->assertSeeHtml('1,123 <span class="text-dimmed text-xs">Cache Hits</span>')
73+
->assertSeeHtml('13,243 <span class="text-dimmed text-xs">Cache Misses</span>')
74+
->assertSeeHtml('Node 2')
75+
->assertSeeHtml('75% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
76+
->assertSeeHtml('6,678 <span class="text-dimmed text-xs">Cache Hits</span>')
77+
->assertSeeHtml('6,654 <span class="text-dimmed text-xs">Cache Misses</span>');
10278
}
10379
}

tests/Unit/Components/VaporDatabaseMetricsComponentTest.php

Lines changed: 17 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -7,37 +7,29 @@
77
use Fidum\VaporMetricsTile\Tests\TestCase;
88
use Fidum\VaporMetricsTile\VaporMetricsClient;
99
use Livewire\Livewire;
10-
use Livewire\Testing\TestableLivewire;
11-
use NunoMaduro\LaravelMojito\ViewAssertion;
1210

1311
class VaporDatabaseMetricsComponentTest extends TestCase
1412
{
1513
public function testMount()
1614
{
17-
$component = new VaporDatabaseMetricsComponent('');
18-
$component->mount('a1:a2', 'My DB Defaults');
19-
20-
$this->assertSame($component->position, 'a1:a2');
21-
$this->assertSame($component->tileName, 'My DB Defaults');
15+
Livewire::test(VaporDatabaseMetricsComponent::class, [
16+
'position' => 'a1:a2',
17+
'tileName' => 'My DB Defaults',
18+
])
19+
->assertSet('position', 'a1:a2')
20+
->assertSet('tileName', 'My DB Defaults');
2221
}
2322

2423
public function testRenderNoResults()
2524
{
26-
/** @var TestableLivewire $result */
27-
$result = Livewire::test(VaporDatabaseMetricsComponent::class)
25+
Livewire::test(VaporDatabaseMetricsComponent::class)
2826
->set('position', 'a1:a2')
2927
->set('tileName', 'My DB Changed')
30-
->call('render');
31-
32-
$html = $result->lastRenderedDom;
33-
34-
$result->assertSee('My DB Changed')
35-
->assertViewHas('refreshIntervalInSeconds', 60);
36-
37-
(new ViewAssertion($html))
38-
->contains('0% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
39-
->contains('0 <span class="text-dimmed text-xs">Average Database Connections</span>')
40-
->contains('0 <span class="text-dimmed text-xs">Max Database Connections</span>');
28+
->assertSee('My DB Changed')
29+
->assertViewHas('refreshIntervalInSeconds', 60)
30+
->assertSeeHtml('0% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
31+
->assertSeeHtml('0 <span class="text-dimmed text-xs">Average Database Connections</span>')
32+
->assertSeeHtml('0 <span class="text-dimmed text-xs">Max Database Connections</span>');
4133
}
4234

4335
public function testRenderSingleNode()
@@ -48,20 +40,12 @@ public function testRenderSingleNode()
4840
'maxDatabaseConnections' => 13243,
4941
]);
5042

51-
/** @var TestableLivewire $result */
52-
$result = Livewire::test(VaporDatabaseMetricsComponent::class)
43+
Livewire::test(VaporDatabaseMetricsComponent::class)
5344
->set('position', 'a1:a2')
5445
->set('tileName', 'My DB Defaults')
55-
->call('render');
56-
57-
$html = $result->lastRenderedDom;
58-
59-
$result->assertSee('My DB Defaults')
60-
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS);
61-
62-
(new ViewAssertion($html))
63-
->contains('43% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
64-
->contains('1,123 <span class="text-dimmed text-xs">Average Database Connections</span>')
65-
->contains('13,243 <span class="text-dimmed text-xs">Max Database Connections</span>');
46+
->assertSee('My DB Defaults')
47+
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS)->assertSeeHtml('43% <span class="text-dimmed text-xs">Average CPU Utilization</span>')
48+
->assertSeeHtml('1,123 <span class="text-dimmed text-xs">Average Database Connections</span>')
49+
->assertSeeHtml('13,243 <span class="text-dimmed text-xs">Max Database Connections</span>');
6650
}
6751
}

tests/Unit/Components/VaporEnvironmentMetricsChartComponentTest.php

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,32 +6,29 @@
66
use Fidum\VaporMetricsTile\Components\VaporEnvironmentMetricsChartComponent;
77
use Fidum\VaporMetricsTile\Tests\TestCase;
88
use Livewire\Livewire;
9-
use Livewire\Testing\TestableLivewire;
109

1110
class VaporEnvironmentMetricsChartComponentTest extends TestCase
1211
{
1312
public function testMount()
1413
{
15-
$component = new VaporEnvironmentMetricsChartComponent('');
16-
$component->mount('a1:a2', 273, 'My Env Defaults', 'test_type', '100vh');
17-
18-
$this->assertSame('a1:a2', $component->position);
19-
$this->assertSame(273, $component->refreshIntervalInSeconds);
20-
$this->assertSame('My Env Defaults', $component->tileName);
21-
$this->assertSame('test_type', $component->type);
22-
$this->assertSame('100vh', $component->height);
14+
Livewire::test(VaporEnvironmentMetricsChartComponent::class, [
15+
'position' => 'a1:a2',
16+
'tileName' => 'My Env Defaults',
17+
'type' => 'test_type',
18+
'height' => '100vh',
19+
])
20+
->assertSet('position', 'a1:a2')
21+
->assertSet('tileName', 'My Env Defaults')
22+
->assertSet('type', 'test_type')
23+
->assertSet('height', '100vh');
2324
}
2425

2526
public function testRender()
2627
{
27-
/** @var TestableLivewire $result */
28-
$result = Livewire::test(VaporEnvironmentMetricsChartComponent::class)
28+
Livewire::test(VaporEnvironmentMetricsChartComponent::class)
2929
->set('position', 'a1:a2')
3030
->set('tileName', 'My Env Changed')
3131
->set('type', ChartType::DEFAULT)
32-
->call('render');
33-
34-
$result
3532
->assertViewHas('tileName', 'My Env Changed')
3633
->assertViewHas('type', ChartType::DEFAULT)
3734
->assertViewHas('refreshIntervalInSeconds', 300)

tests/Unit/Components/VaporEnvironmentMetricsComponentTest.php

Lines changed: 26 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -7,41 +7,33 @@
77
use Fidum\VaporMetricsTile\Tests\TestCase;
88
use Fidum\VaporMetricsTile\VaporMetricsClient;
99
use Livewire\Livewire;
10-
use Livewire\Testing\TestableLivewire;
11-
use NunoMaduro\LaravelMojito\ViewAssertion;
1210

1311
class VaporEnvironmentMetricsComponentTest extends TestCase
1412
{
1513
public function testMount()
1614
{
17-
$component = new VaporEnvironmentMetricsComponent('');
18-
$component->mount('a1:a2', 'My Env Defaults');
19-
20-
$this->assertSame($component->position, 'a1:a2');
21-
$this->assertSame($component->tileName, 'My Env Defaults');
15+
Livewire::test(VaporEnvironmentMetricsComponent::class, [
16+
'position' => 'a1:a2',
17+
'tileName' => 'My Env Defaults',
18+
])
19+
->assertSet('position', 'a1:a2')
20+
->assertSet('tileName', 'My Env Defaults');
2221
}
2322

2423
public function testRenderNoResults()
2524
{
26-
/** @var TestableLivewire $result */
27-
$result = Livewire::test(VaporEnvironmentMetricsComponent::class)
25+
Livewire::test(VaporEnvironmentMetricsComponent::class)
2826
->set('position', 'a1:a2')
2927
->set('tileName', 'My Env Changed')
30-
->call('render');
31-
32-
$html = $result->lastRenderedDom;
33-
34-
$result->assertSee('My Env Changed')
35-
->assertViewHas('refreshIntervalInSeconds', 60);
36-
37-
(new ViewAssertion($html))
38-
->contains('0 <span class="text-dimmed text-xs">API Gateway Requests</span>')
39-
->contains('0 <span class="text-dimmed text-xs">Web Invocations</span>')
40-
->contains('0ms <span class="text-dimmed text-xs">Average Web Duration</span>')
41-
->contains('0 <span class="text-dimmed text-xs">CLI Invocations</span>')
42-
->contains('0ms <span class="text-dimmed text-xs">Average CLI Duration</span>')
43-
->contains('0 <span class="text-dimmed text-xs">Queue Invocations</span>')
44-
->contains('0ms <span class="text-dimmed text-xs">Average Queue Duration</span>');
28+
->assertSee('My Env Changed')
29+
->assertViewHas('refreshIntervalInSeconds', 60)
30+
->assertSeeHtml('0 <span class="text-dimmed text-xs">API Gateway Requests</span>')
31+
->assertSeeHtml('0 <span class="text-dimmed text-xs">Web Invocations</span>')
32+
->assertSeeHtml('0ms <span class="text-dimmed text-xs">Average Web Duration</span>')
33+
->assertSeeHtml('0 <span class="text-dimmed text-xs">CLI Invocations</span>')
34+
->assertSeeHtml('0ms <span class="text-dimmed text-xs">Average CLI Duration</span>')
35+
->assertSeeHtml('0 <span class="text-dimmed text-xs">Queue Invocations</span>')
36+
->assertSeeHtml('0ms <span class="text-dimmed text-xs">Average Queue Duration</span>');
4537
}
4638

4739
public function testRenderSingleNode()
@@ -56,24 +48,17 @@ public function testRenderSingleNode()
5648
'averageQueueFunctionDuration' => 88292.23,
5749
]);
5850

59-
/** @var TestableLivewire $result */
60-
$result = Livewire::test(VaporEnvironmentMetricsComponent::class)
51+
Livewire::test(VaporEnvironmentMetricsComponent::class)
6152
->set('position', 'a1:a2')
6253
->set('tileName', 'My Env Defaults')
63-
->call('render');
64-
65-
$html = $result->lastRenderedDom;
66-
67-
$result->assertSee('My Env Defaults')
68-
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS);
69-
70-
(new ViewAssertion($html))
71-
->contains('79 <span class="text-dimmed text-xs">API Gateway Requests</span>')
72-
->contains('1,239,321 <span class="text-dimmed text-xs">Web Invocations</span>')
73-
->contains('433ms <span class="text-dimmed text-xs">Average Web Duration</span>')
74-
->contains('72,136 <span class="text-dimmed text-xs">CLI Invocations</span>')
75-
->contains('234ms <span class="text-dimmed text-xs">Average CLI Duration</span>')
76-
->contains('971,239 <span class="text-dimmed text-xs">Queue Invocations</span>')
77-
->contains('88,292ms <span class="text-dimmed text-xs">Average Queue Duration</span>');
54+
->assertSee('My Env Defaults')
55+
->assertViewHas('refreshIntervalInSeconds', VaporMetricsClient::DEFAULT_REFRESH_SECONDS)
56+
->assertSeeHtml('79 <span class="text-dimmed text-xs">API Gateway Requests</span>')
57+
->assertSeeHtml('1,239,321 <span class="text-dimmed text-xs">Web Invocations</span>')
58+
->assertSeeHtml('433ms <span class="text-dimmed text-xs">Average Web Duration</span>')
59+
->assertSeeHtml('72,136 <span class="text-dimmed text-xs">CLI Invocations</span>')
60+
->assertSeeHtml('234ms <span class="text-dimmed text-xs">Average CLI Duration</span>')
61+
->assertSeeHtml('971,239 <span class="text-dimmed text-xs">Queue Invocations</span>')
62+
->assertSeeHtml('88,292ms <span class="text-dimmed text-xs">Average Queue Duration</span>');
7863
}
7964
}

0 commit comments

Comments
 (0)