diff --git a/.github/workflows/code_health.yml b/.github/workflows/code_health.yml index 07191b88..f7b2ab2c 100644 --- a/.github/workflows/code_health.yml +++ b/.github/workflows/code_health.yml @@ -78,7 +78,7 @@ jobs: steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: - # The `flutter` command runs some git operations. + fetch-depth: 0 persist-credentials: true # zizmor: ignore[artipacked] - uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2 with: @@ -100,7 +100,7 @@ jobs: swiftformat --version - name: "Dart, Java and Objective-C " run: | - flutter pub global run flutter_plugin_tools format + flutter pub global run flutter_plugin_tools format --base-branch=origin/main ./scripts/validate-formatting.sh - name: "Swift" if: ${{ success() || failure() }} diff --git a/packages/firebase_ui_auth/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt b/packages/firebase_ui_auth/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt index e998cfce..d48e34dc 100644 --- a/packages/firebase_ui_auth/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt +++ b/packages/firebase_ui_auth/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt @@ -2,5 +2,4 @@ package io.flutter.plugins.firebase_ui_example import io.flutter.embedding.android.FlutterActivity -class MainActivity: FlutterActivity() { -} +class MainActivity : FlutterActivity() {} diff --git a/packages/firebase_ui_auth/example/ios/Runner/AppDelegate.swift b/packages/firebase_ui_auth/example/ios/Runner/AppDelegate.swift index 75bd5cea..d4aff80a 100644 --- a/packages/firebase_ui_auth/example/ios/Runner/AppDelegate.swift +++ b/packages/firebase_ui_auth/example/ios/Runner/AppDelegate.swift @@ -1,5 +1,5 @@ -import UIKit import Flutter +import UIKit import app_links @main @@ -14,7 +14,7 @@ import app_links if let url = AppLinks.shared.getLink(launchOptions: launchOptions) { // We have a link, propagate it to your Flutter app or not AppLinks.shared.handleLink(url: url) - return true // Returning true will stop the propagation to other packages + return true // Returning true will stop the propagation to other packages } return super.application(application, didFinishLaunchingWithOptions: launchOptions) diff --git a/packages/firebase_ui_database/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt b/packages/firebase_ui_database/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt index e998cfce..d48e34dc 100644 --- a/packages/firebase_ui_database/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt +++ b/packages/firebase_ui_database/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt @@ -2,5 +2,4 @@ package io.flutter.plugins.firebase_ui_example import io.flutter.embedding.android.FlutterActivity -class MainActivity: FlutterActivity() { -} +class MainActivity : FlutterActivity() {} diff --git a/packages/firebase_ui_database/example/ios/Runner/AppDelegate.swift b/packages/firebase_ui_database/example/ios/Runner/AppDelegate.swift index 70693e4a..9074fee9 100644 --- a/packages/firebase_ui_database/example/ios/Runner/AppDelegate.swift +++ b/packages/firebase_ui_database/example/ios/Runner/AppDelegate.swift @@ -1,5 +1,5 @@ -import UIKit import Flutter +import UIKit @UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { diff --git a/packages/firebase_ui_firestore/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt b/packages/firebase_ui_firestore/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt index e998cfce..d48e34dc 100644 --- a/packages/firebase_ui_firestore/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt +++ b/packages/firebase_ui_firestore/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt @@ -2,5 +2,4 @@ package io.flutter.plugins.firebase_ui_example import io.flutter.embedding.android.FlutterActivity -class MainActivity: FlutterActivity() { -} +class MainActivity : FlutterActivity() {} diff --git a/packages/firebase_ui_firestore/example/ios/Runner/AppDelegate.swift b/packages/firebase_ui_firestore/example/ios/Runner/AppDelegate.swift index 70693e4a..9074fee9 100644 --- a/packages/firebase_ui_firestore/example/ios/Runner/AppDelegate.swift +++ b/packages/firebase_ui_firestore/example/ios/Runner/AppDelegate.swift @@ -1,5 +1,5 @@ -import UIKit import Flutter +import UIKit @UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { diff --git a/packages/firebase_ui_localizations/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_localizations_example/MainActivity.kt b/packages/firebase_ui_localizations/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_localizations_example/MainActivity.kt index 2dd30021..2fc7532b 100644 --- a/packages/firebase_ui_localizations/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_localizations_example/MainActivity.kt +++ b/packages/firebase_ui_localizations/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_localizations_example/MainActivity.kt @@ -2,5 +2,4 @@ package io.flutter.plugins.firebase_ui_localizations_example import io.flutter.embedding.android.FlutterActivity -class MainActivity: FlutterActivity() { -} +class MainActivity : FlutterActivity() {} diff --git a/packages/firebase_ui_localizations/example/ios/Runner/AppDelegate.swift b/packages/firebase_ui_localizations/example/ios/Runner/AppDelegate.swift index 70693e4a..9074fee9 100644 --- a/packages/firebase_ui_localizations/example/ios/Runner/AppDelegate.swift +++ b/packages/firebase_ui_localizations/example/ios/Runner/AppDelegate.swift @@ -1,5 +1,5 @@ -import UIKit import Flutter +import UIKit @UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { diff --git a/packages/firebase_ui_oauth/example/ios/Runner/AppDelegate.swift b/packages/firebase_ui_oauth/example/ios/Runner/AppDelegate.swift index 70693e4a..9074fee9 100644 --- a/packages/firebase_ui_oauth/example/ios/Runner/AppDelegate.swift +++ b/packages/firebase_ui_oauth/example/ios/Runner/AppDelegate.swift @@ -1,5 +1,5 @@ -import UIKit import Flutter +import UIKit @UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { diff --git a/packages/firebase_ui_oauth/example/macos/Runner/AppDelegate.swift b/packages/firebase_ui_oauth/example/macos/Runner/AppDelegate.swift index 5640f7be..cb46c3a4 100644 --- a/packages/firebase_ui_oauth/example/macos/Runner/AppDelegate.swift +++ b/packages/firebase_ui_oauth/example/macos/Runner/AppDelegate.swift @@ -5,13 +5,14 @@ import FlutterMacOS class AppDelegate: FlutterAppDelegate { override func applicationShouldTerminateAfterLastWindowClosed(_ sender: NSApplication) -> Bool { return true - + } - - override func application(_ application:NSApplication, open urls: [URL]) { + + override func application(_ application: NSApplication, open urls: [URL]) { var data: [String: URL] = [:] data["link"] = urls[0] - - NotificationCenter.default.post(Notification(name: Notification.Name(rawValue: "linkReceived"), object: nil, userInfo: data)); + + NotificationCenter.default.post( + Notification(name: Notification.Name(rawValue: "linkReceived"), object: nil, userInfo: data)) } } diff --git a/packages/firebase_ui_oauth/example/macos/Runner/MainFlutterWindow.swift b/packages/firebase_ui_oauth/example/macos/Runner/MainFlutterWindow.swift index 257ae0cd..a3eda9b5 100644 --- a/packages/firebase_ui_oauth/example/macos/Runner/MainFlutterWindow.swift +++ b/packages/firebase_ui_oauth/example/macos/Runner/MainFlutterWindow.swift @@ -9,7 +9,8 @@ class MainFlutterWindow: NSWindow { self.setFrame(windowFrame, display: true) RegisterGeneratedPlugins(registry: flutterViewController) - GoogleSignInMacOSPlugin.register(with: flutterViewController.registrar(forPlugin: "GoogleSignInMacOSPlugin")) + GoogleSignInMacOSPlugin.register( + with: flutterViewController.registrar(forPlugin: "GoogleSignInMacOSPlugin")) super.awakeFromNib() } diff --git a/packages/firebase_ui_storage/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt b/packages/firebase_ui_storage/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt index e998cfce..d48e34dc 100644 --- a/packages/firebase_ui_storage/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt +++ b/packages/firebase_ui_storage/example/android/app/src/main/kotlin/io/flutter/plugins/firebase_ui_example/MainActivity.kt @@ -2,5 +2,4 @@ package io.flutter.plugins.firebase_ui_example import io.flutter.embedding.android.FlutterActivity -class MainActivity: FlutterActivity() { -} +class MainActivity : FlutterActivity() {} diff --git a/packages/firebase_ui_storage/example/ios/Runner/AppDelegate.swift b/packages/firebase_ui_storage/example/ios/Runner/AppDelegate.swift index 70693e4a..9074fee9 100644 --- a/packages/firebase_ui_storage/example/ios/Runner/AppDelegate.swift +++ b/packages/firebase_ui_storage/example/ios/Runner/AppDelegate.swift @@ -1,5 +1,5 @@ -import UIKit import Flutter +import UIKit @UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { diff --git a/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart b/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart index 876fa427..910017ca 100644 --- a/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart +++ b/tests/integration_test/firebase_ui_firestore/firestore_list_view_test.dart @@ -38,15 +38,13 @@ void main() { expect(find.byType(CircularProgressIndicator), findsOneWidget); expect(find.byType(ListView), findsNothing); - await tester.pumpAndSettle(); + await collection.snapshots().first.then((_) {}, onError: (_) {}); + await tester.pump(); verifyZeroInteractions(builderSpy); expect( - find.text( - 'error: [cloud_firestore/permission-denied] ' - 'The caller does not have permission to execute the specified operation.', - ), + find.textContaining('error: [cloud_firestore/permission-denied]'), findsOneWidget, ); expect(find.byType(ListView), findsNothing);