Remove deprecated SemVer tooling (#7611)

Removes all SemVer task tooling, additionally removes tasks only used by
old SemVer tooling.

Modern Metalava based SemVer was slightly refactored to rely on its own
`Delta` class instead of the old `VersionDelta` also used for manual
SemVer.

Author: emilypgoogle

.github/workflows/semver-check.yml

@@ -21,13 +21,10 @@ import com.android.build.gradle.LibraryPlugin
 import com.google.firebase.gradle.plugins.LibraryType.ANDROID
 import com.google.firebase.gradle.plugins.ci.device.FirebaseTestServer
 import com.google.firebase.gradle.plugins.license.LicenseResolverPlugin
-import com.google.firebase.gradle.plugins.semver.ApiDiffer
-import com.google.firebase.gradle.plugins.semver.GmavenCopier
 import org.gradle.api.JavaVersion
 import org.gradle.api.Project
 import org.gradle.api.attributes.Attribute
 import org.gradle.api.publish.tasks.GenerateModuleMetadata
-import org.gradle.api.tasks.Copy
 import org.gradle.kotlin.dsl.apply
 import org.gradle.kotlin.dsl.create
 import org.gradle.kotlin.dsl.getByType
@@ -115,51 +112,6 @@ class FirebaseAndroidLibraryPlugin : BaseFirebaseLibraryPlugin() {
       version.set(firebaseLibrary.version)
       latestReleasedVersion.set(firebaseLibrary.latestReleasedVersion.orElse(""))
     }
-    project.mkdir("semver")
-    project.mkdir("semver/previous-version")
-    project.tasks.register<GmavenCopier>("copyPreviousArtifacts") {
-      dependsOn("bundleReleaseAar")
-      project.file("semver/previous.aar").delete()
-
-      groupId.value(firebaseLibrary.groupId)
-      artifactId.value(firebaseLibrary.artifactId)
-      aarAndroidFile.value(true)
-      filePath.value(project.file("semver/previous.aar").absolutePath)
-    }
-    val artifact = firebaseLibrary.artifactId.get()
-    val releaseAar = if (artifact.contains("-ktx")) "ktx-release.aar" else "${artifact}-release.aar"
-    project.tasks.register<Copy>("extractCurrentClasses") {
-      dependsOn("bundleReleaseAar")
-
-      from(project.zipTree("build/outputs/aar/${releaseAar}"))
-      into(project.file("semver/current-version"))
-    }
-
-    project.tasks.register<Copy>("extractPreviousClasses") {
-      dependsOn("copyPreviousArtifacts")
-      if (
-        GmavenHelper(firebaseLibrary.groupId.get(), firebaseLibrary.artifactId.get())
-          .isPresentInGmaven()
-      ) {
-        from(project.zipTree("semver/previous.aar"))
-        into(project.file("semver/previous-version"))
-      }
-    }
-
-    val currentJarFile = project.file("semver/current-version/classes.jar").absolutePath
-
-    val previousJarFile = project.file("semver/previous-version/classes.jar").absolutePath
-    project.tasks.register<ApiDiffer>("semverCheck") {
-      dependsOn("extractCurrentClasses")
-      dependsOn("extractPreviousClasses")
-      currentJar.value(currentJarFile)
-      previousJar.value(previousJarFile)
-      version.value(firebaseLibrary.version)
-      previousVersionString.value(
-        GmavenHelper(firebaseLibrary.groupId.get(), firebaseLibrary.artifactId.get())
-          .getLatestReleasedVersion()
-      )
-    }
 
     setupMetalavaSemver(project, firebaseLibrary)
   }

plugins/src/main/java/com/google/firebase/gradle/plugins/FirebaseAndroidLibraryPlugin.kt

@@ -17,8 +17,6 @@
 package com.google.firebase.gradle.plugins
 
 import com.google.firebase.gradle.plugins.LibraryType.JAVA
-import com.google.firebase.gradle.plugins.semver.ApiDiffer
-import com.google.firebase.gradle.plugins.semver.GmavenCopier
 import org.gradle.api.Project
 import org.gradle.api.attributes.Attribute
 import org.gradle.api.plugins.JavaLibraryPlugin
@@ -78,31 +76,6 @@ class FirebaseJavaLibraryPlugin : BaseFirebaseLibraryPlugin() {
       version.value(firebaseLibrary.version)
       latestReleasedVersion.value(firebaseLibrary.latestReleasedVersion.orElse(""))
     }
-    project.mkdir("semver")
-    project.tasks.register<GmavenCopier>("copyPreviousArtifacts") {
-      dependsOn("jar")
-      project.file("semver/previous.jar").delete()
-      groupId.value(firebaseLibrary.groupId.get())
-      artifactId.value(firebaseLibrary.artifactId.get())
-      aarAndroidFile.value(false)
-      filePath.value(project.file("semver/previous.jar").absolutePath)
-    }
-    val currentJarFile =
-      project
-        .file("build/libs/${firebaseLibrary.artifactId.get()}-${firebaseLibrary.version}.jar")
-        .absolutePath
-    val previousJarFile = project.file("semver/previous.jar").absolutePath
-    project.tasks.register<ApiDiffer>("semverCheck") {
-      currentJar.value(currentJarFile)
-      previousJar.value(previousJarFile)
-      version.value(firebaseLibrary.version)
-      previousVersionString.value(
-        GmavenHelper(firebaseLibrary.groupId.get(), firebaseLibrary.artifactId.get())
-          .getLatestReleasedVersion()
-      )
-
-      dependsOn("copyPreviousArtifacts")
-    }
 
     setupMetalavaSemver(project, firebaseLibrary)
   }

plugins/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.kt

@@ -69,7 +69,6 @@ import org.gradle.kotlin.dsl.register
  * - [RELEASE_GENEATOR_TASK][registerGenerateReleaseConfigFilesTask]
  * - [RELEASE_REPORT_GENERATOR_TASK][registerGenerateReleaseReportFilesTask]
  * - [PUBLISH_RELEASING_LIBS_TO_LOCAL_TASK][registerPublishReleasingLibrariesToMavenLocalTask]
- * - [SEMVER_CHECK_TASK][registerSemverCheckForReleaseTask]
  * - [PUBLISH_ALL_TO_BUILD_TASK][registerPublishAllToBuildDir]
  * - [LIBRARY_GROUPS_TASK][registerLibraryGroupsTask]
  *
@@ -116,7 +115,6 @@ abstract class PublishingPlugin : Plugin<Project> {
 
       registerGenerateReleaseConfigFilesTask(project, libraryGroups, releaseReportTask)
       registerPublishReleasingLibrariesToMavenLocalTask(project, releasingProjects)
-      registerSemverCheckForReleaseTask(project, releasingProjects)
       registerPublishAllToBuildDir(project, allFirebaseLibraries)
       registerPostReleasePlugin(releasingProjects)
       registerLibraryGroupsTask(project, libraryGroups)
@@ -711,25 +709,6 @@ abstract class PublishingPlugin : Plugin<Project> {
       }
     }
 
-  /**
-   * Registers the [SEMVER_CHECK_TASK] task.
-   *
-   * A collection of [ApiDiffer] for each releasing project.
-   *
-   * Ensures that the version of a releasing project aligns with the API. That is, if the API shows
-   * signs of a major or minor bump- the version is bumped as expected.
-   */
-  private fun registerSemverCheckForReleaseTask(
-    project: Project,
-    releasingProjects: List<Project>,
-  ) =
-    project.tasks.register(SEMVER_CHECK_TASK) {
-      for (releasingProject in releasingProjects) {
-        val semverCheckTask = releasingProject.tasks.named("semverCheck")
-        dependsOn(semverCheckTask)
-      }
-    }
-
   /**
    * Registers the [PUBLISH_ALL_TO_BUILD_TASK] task.
    *
@@ -770,7 +749,6 @@ abstract class PublishingPlugin : Plugin<Project> {
     const val GENERATE_TUTORIAL_BUNDLE_TASK = "generateTutorialBundle"
     const val VALIDATE_PROJECTS_TO_PUBLISH_TASK = "validateProjectsToPublish"
     const val VALIDATE_LIBRARY_GROUPS_TO_PUBLISH_TASK = "validateLibraryGroupsToPublish"
-    const val SEMVER_CHECK_TASK = "semverCheckForRelease"
     const val RELEASE_GENEATOR_TASK = "generateReleaseConfig"
     const val RELEASE_REPORT_GENERATOR_TASK = "generateReleaseReport"
     const val VALIDATE_POM_TASK = "validatePomForRelease"

plugins/src/main/java/com/google/firebase/gradle/plugins/PublishingPlugin.kt

@@ -16,7 +16,6 @@
 
 package com.google.firebase.gradle.plugins
 
-import com.google.firebase.gradle.plugins.semver.VersionDelta
 import java.io.ByteArrayOutputStream
 import javax.inject.Inject
 import org.gradle.api.DefaultTask
@@ -44,9 +43,9 @@ abstract class SemVerTask @Inject constructor(private val execOperations: ExecOp
 
     val bump =
       when {
-        previous.major != current.major -> VersionDelta.MAJOR
-        previous.minor != current.minor -> VersionDelta.MINOR
-        else -> VersionDelta.PATCH
+        previous.major != current.major -> Delta.MAJOR
+        previous.minor != current.minor -> Delta.MINOR
+        else -> Delta.PATCH
       }
     val stream = ByteArrayOutputStream()
     project.runMetalavaWithArgs(
@@ -84,13 +83,13 @@ abstract class SemVerTask @Inject constructor(private val execOperations: ExecOp
       (majorChanges.joinToString(separator = "") { m -> "  MAJOR: $m\n" }) +
         minorChanges.joinToString(separator = "") { m -> "  MINOR: $m\n" }
     if (majorChanges.isNotEmpty()) {
-      if (bump != VersionDelta.MAJOR) {
+      if (bump != Delta.MAJOR) {
         throw GradleException(
           "API has non-bumped breaking MAJOR changes\nCurrent version bump is ${bump}, update the gradle.properties or fix the changes\n$allChanges"
         )
       }
     } else if (minorChanges.isNotEmpty()) {
-      if (bump != VersionDelta.MAJOR && bump != VersionDelta.MINOR) {
+      if (bump != Delta.MAJOR && bump != Delta.MINOR) {
         throw GradleException(
           "API has non-bumped MINOR changes\nCurrent version bump is ${bump}, update the gradle.properties or fix the changes\n$allChanges"
         )
@@ -103,4 +102,10 @@ abstract class SemVerTask @Inject constructor(private val execOperations: ExecOp
     private val MINOR = setOf("AddedClass", "AddedMethod", "AddedField", "ChangedDeprecated")
     private val IGNORED = setOf("ReferencesDeprecated")
   }
+
+  enum class Delta {
+    MAJOR,
+    MINOR,
+    PATCH,
+  }
 }