fix: do not retry on http 404

Author: 0x416e746f6e

server/download.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/flashbots/gh-artifacts-sync/logutils"
+	"github.com/flashbots/gh-artifacts-sync/utils"
 
 	"go.uber.org/zap"
 )
@@ -38,6 +39,9 @@ func (s *Server) downloadUrl(
 		res, err := cli.Do(req)
 		if err == nil && res.StatusCode != http.StatusOK {
 			err = fmt.Errorf("unexpected http status: %d", res.StatusCode)
+			if res.StatusCode == http.StatusNotFound {
+				err = utils.DoNotRetry(err)
+			}
 		}
 		if err != nil {
 			return fmt.Errorf("failed to execute http request: %w", err)

server/upload_gcp_docker.go

@@ -89,7 +89,7 @@ func (s *Server) uploadFromZipToGcpArtifactRegistryDocker(
 
 		transportErr := &crtransport.Error{}
 		if errors.As(uploadErr, &transportErr) && !transportErr.Temporary() {
-			uploadErr = utils.NoRetry(uploadErr)
+			uploadErr = utils.DoNotRetry(uploadErr)
 		}
 
 		return uploadErr

utils/errors.go

@@ -4,7 +4,7 @@ type NonRetryableError struct {
 	err error
 }
 
-func NoRetry(err error) error {
+func DoNotRetry(err error) error {
 	return &NonRetryableError{err: err}
 }