flatpak-node-generator: produces invalid symlink paths

[jwillikers]

flatpak-builder version

1.4.4

Linux distribution and version

Fedora 43

Affected flatpak-builder tool

node/flatpak-node-generator.py

flatpak-builder tool cli args

npm --electron-node-headers

Source repository URL

https://github.com/hovancik/stretchly/tree/v1.20.0

Flatpak-builder manifest URL

https://github.com/flathub/net.hovancik.Stretchly/blob/332a097bdd7c4e180b1a4251f1b8725131e59d41/net.hovancik.Stretchly.yaml

Description

> Stretchly@1.20.0 pack
> electron-builder build --dir --x64 --linux

  • electron-builder  version=26.0.12 os=6.19.6-200.fc43.x86_64
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • executing @electron/rebuild  electronVersion=39.2.7 arch=x64 buildFromSource=false appDir=./
  • installing native dependencies  arch=x64
  • preparing       moduleName=windows-focus-assist arch=x64
  • finished        moduleName=windows-focus-assist arch=x64
  • completed installing native dependencies
  • packaging       platform=linux arch=x64 electron=39.2.7 appOutDir=dist/linux-unpacked
  ⨯ ENOENT: no such file or directory, stat '/run/build/stretchly/flatpak-node/cache/esbuild/bin/esbuild-current'  failedTask=build stackTrace=Error: ENOENT: no such file or directory, stat '/run/build/stretchly/flatpak-node/cache/esbuild/bin/esbuild-current'
Error: module stretchly: Child process exited with code 1

The esbuild-current symlink links to the file linux-x64@0.27.2 on x86_64, but the executable doesn't actually exist it this location. Instead, it is located under the @esbuild subdirectory in the same directory. I manually patched the generated-sources'json in this commit to workaround this issue.

The PR where this issue surfaced is flathub/net.hovancik.Stretchly#27.