Improving tests for hints

Author: jpmonettas

test/clojure/test_clojure/storm_test_code/hints.clj

@@ -0,0 +1,28 @@
+(ns clojure.test-clojure.storm-test-code.hints
+  (:import (clojure.testfixtures Component MyView MyView$Builder)
+           (java.util.concurrent Executors)))
+
+(def form-1
+  "Returns a function that executes the inline .build call (previously failing)."
+  (fn []
+    (-> (Component/newBuilder)
+        (.setMyView ^MyView$Builder
+         (.build (MyView/newBuilder)))
+        .build)))
+
+(def form-2
+  "Returns a function that executes the threaded -> form (was expected to succeed)."
+  (fn []
+    (-> (Component/newBuilder)
+        (.setMyView ^MyView$Builder
+         (-> (MyView/newBuilder)
+             .build))
+        .build)))
+
+(def form-3
+  "Returns a function that executes a form that needs the type hint befor the (fn ...) macro to succed"
+  (fn []
+    (.submit (Executors/newFixedThreadPool 10) ^Callable (fn [] 42))))
+
+
+

test/clojure/test_clojure/storm_typehint_bug.clj

@@ -1,26 +1,10 @@
 (ns clojure.test-clojure.storm-typehint-bug
   (:require
-   [clojure.test :refer [deftest is testing]])
-  (:import (clojure.testfixtures Component MyView MyView$Builder)))
-
-(def form-1
-  "Returns a function that executes the inline .build call (previously failing)."
-  (fn []
-    (-> (Component/newBuilder)
-        (.setMyView ^MyView$Builder
-         (.build (MyView/newBuilder)))
-        .build)))
-
-(def form-2
-  "Returns a function that executes the threaded -> form (was expected to succeed)."
-  (fn []
-    (-> (Component/newBuilder)
-        (.setMyView ^MyView$Builder
-         (-> (MyView/newBuilder)
-             .build))
-        .build)))
+   [clojure.test :refer [deftest is testing]]
+   [clojure.test-clojure.storm-test-code.hints :as hints]))
 
 (deftest wrong-type-hint-falls-back-to-reflection-test
   (testing "Flow-Storm instrumentation matches Clojure's fallback for incorrect hints"
-    (is (thrown? java.lang.ClassCastException (form-1)))
-    (is (some? (form-2)))))
+    (is (thrown? java.lang.ClassCastException (hints/form-1)))
+    (is (some? (hints/form-2)))
+    (is (some? (hints/form-3)))))