lint: misc

Author: fulleni

analysis_options.yaml

@@ -6,6 +6,7 @@ analyzer:
     no_default_cases: ignore
     avoid_catches_without_on_clauses: ignore
     lines_longer_than_80_chars: ignore
+    avoid_dynamic_calls: ignore
   exclude:
     - build/**
 linter:

lib/src/services/jwt_auth_token_service.dart

@@ -75,7 +75,7 @@ class JwtAuthTokenService implements AuthTokenService {
       print('Error generating JWT for user ${user.id}: $e');
       // Map to a standard exception
       throw OperationFailedException(
-        'Failed to generate authentication token: ${e.toString()}',
+        'Failed to generate authentication token: $e',
       );
     }
   }
@@ -91,7 +91,8 @@ class JwtAuthTokenService implements AuthTokenService {
       if (userId == null) {
         print('Token validation failed: Missing "sub" claim.');
         // Throw specific exception for malformed token
-        throw const BadRequestException('Malformed token: Missing subject claim.');
+        throw const BadRequestException(
+            'Malformed token: Missing subject claim.',);
       }
 
       // Fetch the full user object from the repository
@@ -107,7 +108,8 @@ class JwtAuthTokenService implements AuthTokenService {
       print('Token validation failed: Invalid token. Reason: ${e.message}');
       // Throw specific exception for invalid token signature/format
       throw UnauthorizedException('Invalid token: ${e.message}');
-    } on JWTException catch (e) { // Use JWTException as the general catch-all
+    } on JWTException catch (e) {
+      // Use JWTException as the general catch-all
       print('Token validation failed: JWT Exception. Reason: ${e.message}');
       // Treat other JWT exceptions as invalid tokens
       throw UnauthorizedException('Invalid token: ${e.message}');
@@ -121,7 +123,7 @@ class JwtAuthTokenService implements AuthTokenService {
       print('Unexpected error during token validation: $e');
       // Wrap unexpected errors in a standard exception type
       throw OperationFailedException(
-        'Token validation failed unexpectedly: ${e.toString()}',
+        'Token validation failed unexpectedly: $e',
       );
     }
   }

routes/_middleware.dart

@@ -9,9 +9,6 @@ import 'package:dart_frog/dart_frog.dart';
 import 'package:ht_api/src/middlewares/authentication_middleware.dart';
 import 'package:ht_api/src/middlewares/error_handler.dart';
 import 'package:ht_api/src/registry/model_registry.dart';
-import 'package:ht_api/src/middlewares/authentication_middleware.dart';
-import 'package:ht_api/src/middlewares/error_handler.dart';
-import 'package:ht_api/src/registry/model_registry.dart';
 import 'package:ht_api/src/services/auth_service.dart';
 import 'package:ht_api/src/services/auth_token_service.dart';
 // Import the new JWT service

test/helpers/create_mock_request_context.dart

@@ -1,10 +1,10 @@
 import 'package:dart_frog/dart_frog.dart';
-import 'package:ht_api/src/registry/model_registry.dart'; // For RequestId
+// For RequestId
 import 'package:ht_api/src/services/auth_service.dart'; // Import necessary types
 import 'package:ht_data_repository/ht_data_repository.dart'; // For HtDataRepository
 import 'package:ht_shared/ht_shared.dart'; // For User
 import 'package:mocktail/mocktail.dart';
-import 'package:test/test.dart'; // Import for TypeMatcher and isA
+// Import for TypeMatcher and isA
 
 import '../../routes/_middleware.dart'; // Import for RequestId
 import 'mock_classes.dart'; // Import your mock classes
@@ -28,7 +28,8 @@ RequestContext createMockRequestContext({
   dependencies.forEach((type, instance) {
     // Add specific stubs for known types. Extend this list as needed.
     if (type == AuthService) {
-      when(() => context.read<AuthService>()).thenReturn(instance as AuthService);
+      when(() => context.read<AuthService>())
+          .thenReturn(instance as AuthService);
     } else if (type == HtDataRepository<User>) {
       when(() => context.read<HtDataRepository<User>>())
           .thenReturn(instance as HtDataRepository<User>);
@@ -52,12 +53,12 @@ RequestContext createMockRequestContext({
       // This generic stub might not always work as expected.
       // Use a specific type if possible, otherwise fallback carefully.
       try {
-         // Stubbing read<dynamic>() can be tricky. Prefer specific types.
-         // If absolutely needed, ensure the call signature matches.
-         // Mocktail's `any` matcher doesn't take arguments for `read`.
-         when(() => context.read<dynamic>()).thenReturn(instance);
+        // Stubbing read<dynamic>() can be tricky. Prefer specific types.
+        // If absolutely needed, ensure the call signature matches.
+        // Mocktail's `any` matcher doesn't take arguments for `read`.
+        when(() => context.read<dynamic>()).thenReturn(instance);
       } catch (e) {
-         print('Failed to setup generic read stub for $type: $e');
+        print('Failed to setup generic read stub for $type: $e');
       }
     }
   });
@@ -77,7 +78,8 @@ RequestContext createMockRequestContext({
   // to allow chaining, which is typical for provider middleware.
   // Corrected: provide takes one argument (the provider function).
   // Use `any<T>()` with explicit type argument for the function.
-  when(() => context.provide<dynamic>(any<dynamic Function()>())).thenReturn(context);
+  when(() => context.provide<dynamic>(any<dynamic Function()>()))
+      .thenReturn(context);
 
   return context;
 }

test/helpers/mock_classes.dart

@@ -11,25 +11,38 @@ import 'package:uuid/uuid.dart';
 
 // Core Dart Frog Mocks
 class MockRequestContext extends Mock implements RequestContext {}
+
 class MockRequest extends Mock implements Request {}
+
 class MockResponse extends Mock implements Response {}
+
 class MockUri extends Mock implements Uri {}
 
 // Service Mocks
 class MockAuthService extends Mock implements AuthService {}
+
 class MockAuthTokenService extends Mock implements AuthTokenService {}
+
 class MockVerificationCodeStorageService extends Mock
     implements VerificationCodeStorageService {}
 
 // Repository Mocks
 class MockHtDataRepository<T> extends Mock implements HtDataRepository<T> {}
+
 class MockUserRepository extends MockHtDataRepository<User> {}
+
 class MockHeadlineRepository extends MockHtDataRepository<Headline> {}
+
 class MockCategoryRepository extends MockHtDataRepository<Category> {}
+
 class MockSourceRepository extends MockHtDataRepository<Source> {}
+
 class MockCountryRepository extends MockHtDataRepository<Country> {}
+
 // Corrected: Use 'extends Mock implements' for concrete classes
-class MockAppSettingsRepository extends Mock implements HtAppSettingsRepository {}
+class MockAppSettingsRepository extends Mock
+    implements HtAppSettingsRepository {}
+
 class MockEmailRepository extends Mock implements HtEmailRepository {}
 
 // Utility Mocks

test/routes/api/v1/auth/anonymous_test.dart

@@ -7,23 +7,23 @@ import 'package:ht_shared/ht_shared.dart';
 import 'package:mocktail/mocktail.dart';
 import 'package:test/test.dart';
 
-import '../../../../helpers/create_mock_request_context.dart';
-import '../../../../helpers/mock_classes.dart';
 // Import the actual route handler
 import '../../../../../routes/api/v1/auth/anonymous.dart' as route;
+import '../../../../helpers/create_mock_request_context.dart';
+import '../../../../helpers/mock_classes.dart';
 
 void main() {
   group('POST /api/v1/auth/anonymous', () {
     late MockAuthService mockAuthService;
     late MockRequest mockRequest;
 
     // Define a sample user and token for success cases
-    final testUser = User(id: 'anon-123', isAnonymous: true);
+    const testUser = User(id: 'anon-123', isAnonymous: true);
     const testToken = 'test-auth-token';
-    final authResult = (user: testUser, token: testToken);
+    const authResult = (user: testUser, token: testToken);
 
     // Expected success response payload
-    final successPayload = SuccessApiResponse<AuthSuccessResponse>(
+    const successPayload = SuccessApiResponse<AuthSuccessResponse>(
       data: AuthSuccessResponse(user: testUser, token: testToken),
     );
     final expectedSuccessBody = jsonEncode(
@@ -40,7 +40,8 @@ void main() {
       when(() => mockRequest.headers).thenReturn({});
       // Default stub for body (can be overridden)
       when(() => mockRequest.body()).thenAnswer((_) async => '');
-      when(() => mockRequest.json()).thenAnswer((_) async => <String, dynamic>{});
+      when(() => mockRequest.json())
+          .thenAnswer((_) async => <String, dynamic>{});
     });
 
     test('returns 200 OK with user and token on successful anonymous sign-in',
@@ -90,7 +91,8 @@ void main() {
       verifyNever(() => mockAuthService.performAnonymousSignIn());
     });
 
-    test('returns 500 Internal Server Error when AuthService throws OperationFailedException',
+    test(
+        'returns 500 Internal Server Error when AuthService throws OperationFailedException',
         () async {
       // Arrange
       const exception = OperationFailedException('Database connection failed');
@@ -114,7 +116,7 @@ void main() {
       // The final 500 response format is tested in the error handler middleware tests.
     });
 
-     test('returns 500 Internal Server Error for unexpected errors', () async {
+    test('returns 500 Internal Server Error for unexpected errors', () async {
       // Arrange
       final exception = Exception('Something unexpected went wrong');
       when(() => mockAuthService.performAnonymousSignIn()).thenThrow(exception);
@@ -130,11 +132,13 @@ void main() {
       // The handler catches generic exceptions and throws OperationFailedException
       expect(
         () => route.onRequest(context),
-        throwsA(isA<OperationFailedException>().having(
-              (e) => e.message,
-              'message',
-              'An unexpected error occurred during anonymous sign-in.',
-            )),
+        throwsA(
+          isA<OperationFailedException>().having(
+            (e) => e.message,
+            'message',
+            'An unexpected error occurred during anonymous sign-in.',
+          ),
+        ),
       );
       verify(() => mockAuthService.performAnonymousSignIn()).called(1);
     });

test/routes/api/v1/auth/me_test.dart

@@ -6,20 +6,19 @@ import 'package:ht_shared/ht_shared.dart';
 import 'package:mocktail/mocktail.dart';
 import 'package:test/test.dart';
 
-import '../../../../helpers/create_mock_request_context.dart';
-import '../../../../helpers/mock_classes.dart';
-// Import the actual route handler
-import '../../../../../routes/api/v1/auth/me.dart' as route;
 // Import RequestId definition from middleware file
 import '../../../../../routes/_middleware.dart' show RequestId;
-
+// Import the actual route handler
+import '../../../../../routes/api/v1/auth/me.dart' as route;
+import '../../../../helpers/create_mock_request_context.dart';
+import '../../../../helpers/mock_classes.dart';
 
 void main() {
   group('GET /api/v1/auth/me', () {
     late MockRequest mockRequest;
 
     // Define a sample authenticated user
-    final testUser = User(
+    const testUser = User(
       id: 'user-123',
       email: 'test@example.com',
       isAnonymous: false,
@@ -38,11 +37,10 @@ void main() {
     test('returns 200 OK with user data for authenticated user', () async {
       // Arrange
       // Expected success response payload (metadata timestamp will vary)
-      final expectedPayload = SuccessApiResponse<User>(data: testUser);
+      const expectedPayload = SuccessApiResponse<User>(data: testUser);
       final expectedBody = jsonEncode(
         // We ignore metadata for direct comparison as timestamp varies
-        expectedPayload.toJson((user) => user.toJson())
-          ..remove('metadata'),
+        expectedPayload.toJson((user) => user.toJson())..remove('metadata'),
       );
 
       final context = createMockRequestContext(
@@ -70,18 +68,19 @@ void main() {
       );
       // Check metadata structure and requestId presence
       expect(decodedBody['metadata'], isA<Map<String, dynamic>>());
-      expect(decodedBody['metadata']?['request_id'], equals(testRequestIdValue));
+      expect(
+          decodedBody['metadata']?['request_id'], equals(testRequestIdValue),);
       expect(decodedBody['metadata']?['timestamp'], isNotNull);
     });
 
-     test('returns 200 OK with user data when RequestId is not in context', () async {
+    test('returns 200 OK with user data when RequestId is not in context',
+        () async {
       // Arrange
       // Expected success response payload (metadata timestamp will vary)
-      final expectedPayload = SuccessApiResponse<User>(data: testUser);
+      const expectedPayload = SuccessApiResponse<User>(data: testUser);
       final expectedBody = jsonEncode(
         // We ignore metadata for direct comparison as timestamp varies
-        expectedPayload.toJson((user) => user.toJson())
-          ..remove('metadata'),
+        expectedPayload.toJson((user) => user.toJson())..remove('metadata'),
       );
 
       final context = createMockRequestContext(
@@ -112,7 +111,6 @@ void main() {
       expect(decodedBody['metadata']?['timestamp'], isNotNull);
     });
 
-
     test('returns 405 Method Not Allowed for non-GET requests', () async {
       // Arrange
       when(() => mockRequest.method).thenReturn(HttpMethod.post); // Test POST