From 7bf4644c461257072125c014afc0ddf5a81bb95c Mon Sep 17 00:00:00 2001 From: JunsuChoi Date: Thu, 5 Feb 2026 10:41:52 +0900 Subject: [PATCH 1/2] [video_player_avplay/videohole] Remove unused proxy apis --- packages/video_player_avplay/CHANGELOG.md | 1 + .../tizen/src/ecore_wl2_window_proxy.cc | 15 --------------- .../tizen/src/ecore_wl2_window_proxy.h | 1 - packages/video_player_videohole/CHANGELOG.md | 1 + .../tizen/src/ecore_wl2_window_proxy.cc | 15 --------------- .../tizen/src/ecore_wl2_window_proxy.h | 1 - 6 files changed, 2 insertions(+), 32 deletions(-) diff --git a/packages/video_player_avplay/CHANGELOG.md b/packages/video_player_avplay/CHANGELOG.md index 2c9dc9193..8ebfb5580 100644 --- a/packages/video_player_avplay/CHANGELOG.md +++ b/packages/video_player_avplay/CHANGELOG.md @@ -1,6 +1,7 @@ ## NEXT * Adds compatibility with `http` 1.0 in example. +* Remove unused proxy apis. ## 0.8.1 diff --git a/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc b/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc index 0e8891ffb..670458184 100644 --- a/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc +++ b/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc @@ -37,21 +37,6 @@ void EcoreWl2WindowProxy::ecore_wl2_window_geometry_get(void *window, int *x, ecore_wl2_window_geometry_get(window, x, y, width, height); } -int EcoreWl2WindowProxy::ecore_wl2_window_surface_id_get(void *window) { - if (!ecore_wl2_window_handle_) { - LOG_ERROR("ecore_wl2_window_handle_ not valid"); - return -1; - } - FuncEcoreWl2WindowSurfaceIdGet ecore_wl2_window_surface_id_get = - reinterpret_cast( - dlsym(ecore_wl2_window_handle_, "ecore_wl2_window_surface_id_get")); - if (!ecore_wl2_window_surface_id_get) { - LOG_ERROR("Fail to find ecore_wl2_window_surface_id_get."); - return -1; - } - return ecore_wl2_window_surface_id_get(window); -} - EcoreWl2WindowProxy::~EcoreWl2WindowProxy() { if (ecore_wl2_window_handle_) { dlclose(ecore_wl2_window_handle_); diff --git a/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.h b/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.h index 66c4aa3cc..f8545a457 100644 --- a/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.h +++ b/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.h @@ -11,7 +11,6 @@ class EcoreWl2WindowProxy { ~EcoreWl2WindowProxy(); void ecore_wl2_window_geometry_get(void *window, int *x, int *y, int *width, int *height); - int ecore_wl2_window_surface_id_get(void *window); private: void *ecore_wl2_window_handle_ = nullptr; diff --git a/packages/video_player_videohole/CHANGELOG.md b/packages/video_player_videohole/CHANGELOG.md index f3a647679..93f716f19 100644 --- a/packages/video_player_videohole/CHANGELOG.md +++ b/packages/video_player_videohole/CHANGELOG.md @@ -1,6 +1,7 @@ ## NEXT * Adds compatibility with `http` 1.0 in example. +* Remove unused proxy apis. ## 0.5.8 diff --git a/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc b/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc index 0e8891ffb..670458184 100644 --- a/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc +++ b/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc @@ -37,21 +37,6 @@ void EcoreWl2WindowProxy::ecore_wl2_window_geometry_get(void *window, int *x, ecore_wl2_window_geometry_get(window, x, y, width, height); } -int EcoreWl2WindowProxy::ecore_wl2_window_surface_id_get(void *window) { - if (!ecore_wl2_window_handle_) { - LOG_ERROR("ecore_wl2_window_handle_ not valid"); - return -1; - } - FuncEcoreWl2WindowSurfaceIdGet ecore_wl2_window_surface_id_get = - reinterpret_cast( - dlsym(ecore_wl2_window_handle_, "ecore_wl2_window_surface_id_get")); - if (!ecore_wl2_window_surface_id_get) { - LOG_ERROR("Fail to find ecore_wl2_window_surface_id_get."); - return -1; - } - return ecore_wl2_window_surface_id_get(window); -} - EcoreWl2WindowProxy::~EcoreWl2WindowProxy() { if (ecore_wl2_window_handle_) { dlclose(ecore_wl2_window_handle_); diff --git a/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.h b/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.h index 66c4aa3cc..f8545a457 100644 --- a/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.h +++ b/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.h @@ -11,7 +11,6 @@ class EcoreWl2WindowProxy { ~EcoreWl2WindowProxy(); void ecore_wl2_window_geometry_get(void *window, int *x, int *y, int *width, int *height); - int ecore_wl2_window_surface_id_get(void *window); private: void *ecore_wl2_window_handle_ = nullptr; From c83100111b3d35ce86205cbff1fc02586133ffb1 Mon Sep 17 00:00:00 2001 From: JunsuChoi Date: Thu, 5 Feb 2026 11:03:15 +0900 Subject: [PATCH 2/2] ++ --- packages/video_player_avplay/CHANGELOG.md | 2 +- .../video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc | 1 - packages/video_player_videohole/CHANGELOG.md | 2 +- .../video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc | 1 - 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/video_player_avplay/CHANGELOG.md b/packages/video_player_avplay/CHANGELOG.md index 8ebfb5580..ef423e385 100644 --- a/packages/video_player_avplay/CHANGELOG.md +++ b/packages/video_player_avplay/CHANGELOG.md @@ -1,7 +1,7 @@ ## NEXT * Adds compatibility with `http` 1.0 in example. -* Remove unused proxy apis. +* Removed unused proxy APIs. ## 0.8.1 diff --git a/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc b/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc index 670458184..ea6f0ef98 100644 --- a/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc +++ b/packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc @@ -10,7 +10,6 @@ typedef void (*FuncEcoreWl2WindowGeometryGet)(void *window, int *x, int *y, int *width, int *height); -typedef int (*FuncEcoreWl2WindowSurfaceIdGet)(void *window); EcoreWl2WindowProxy::EcoreWl2WindowProxy() { ecore_wl2_window_handle_ = dlopen("libecore_wl2.so.1", RTLD_LAZY); diff --git a/packages/video_player_videohole/CHANGELOG.md b/packages/video_player_videohole/CHANGELOG.md index 93f716f19..e8c9f4df8 100644 --- a/packages/video_player_videohole/CHANGELOG.md +++ b/packages/video_player_videohole/CHANGELOG.md @@ -1,7 +1,7 @@ ## NEXT * Adds compatibility with `http` 1.0 in example. -* Remove unused proxy apis. +* Removed unused proxy APIs. ## 0.5.8 diff --git a/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc b/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc index 670458184..ea6f0ef98 100644 --- a/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc +++ b/packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc @@ -10,7 +10,6 @@ typedef void (*FuncEcoreWl2WindowGeometryGet)(void *window, int *x, int *y, int *width, int *height); -typedef int (*FuncEcoreWl2WindowSurfaceIdGet)(void *window); EcoreWl2WindowProxy::EcoreWl2WindowProxy() { ecore_wl2_window_handle_ = dlopen("libecore_wl2.so.1", RTLD_LAZY);