From 4500df4bfbc32eb8b3eabe3bf906ed455a527a1f Mon Sep 17 00:00:00 2001 From: Danny Tuppeny Date: Wed, 17 Dec 2025 16:07:45 +0000 Subject: [PATCH 1/2] Move property_editor/reconnecting_overlay.dart -> not_connected_overlay.dart The changes I made to this file prevented git from detecting it as a rename in my previous PR. To slightly simplify the review, I left the file where it was with a TODO to move after. This is just that move. --- ...econnecting_overlay.dart => not_connected_overlay.dart} | 7 ++----- .../lib/src/standalone_ui/standalone_screen.dart | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) rename packages/devtools_app/lib/src/standalone_ui/ide_shared/{property_editor/reconnecting_overlay.dart => not_connected_overlay.dart} (91%) diff --git a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/reconnecting_overlay.dart b/packages/devtools_app/lib/src/standalone_ui/ide_shared/not_connected_overlay.dart similarity index 91% rename from packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/reconnecting_overlay.dart rename to packages/devtools_app/lib/src/standalone_ui/ide_shared/not_connected_overlay.dart index aac701f0390..0a67722ffdd 100644 --- a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/reconnecting_overlay.dart +++ b/packages/devtools_app/lib/src/standalone_ui/ide_shared/not_connected_overlay.dart @@ -6,11 +6,8 @@ import 'package:devtools_app_shared/service.dart'; import 'package:devtools_app_shared/ui.dart'; import 'package:flutter/material.dart'; -import '../../../shared/globals.dart'; -import '../../../shared/ui/common_widgets.dart'; - -// TODO(dantup): Rename and move this file one level up. Leaving as-is to -// make the review/diff simpler. +import '../../shared/globals.dart'; +import '../../shared/ui/common_widgets.dart'; /// An overlay to show when we are not connected to DTD based on the /// [DTDConnectionState] classes. diff --git a/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart b/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart index 6a1f64a7de1..af4af1f1f8b 100644 --- a/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart +++ b/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart @@ -9,7 +9,7 @@ import 'package:flutter/material.dart'; import '../shared/globals.dart'; import '../shared/ui/common_widgets.dart'; import 'ide_shared/property_editor/property_editor_panel.dart'; -import 'ide_shared/property_editor/reconnecting_overlay.dart'; +import 'ide_shared/not_connected_overlay.dart'; import 'vs_code/flutter_panel.dart'; /// "Screens" that are intended for standalone use only, likely for embedding From 689eeeb2292bde586bdbcc342c5f4d955b3e43a2 Mon Sep 17 00:00:00 2001 From: Danny Tuppeny Date: Wed, 17 Dec 2025 16:18:04 +0000 Subject: [PATCH 2/2] Sort imports --- .../devtools_app/lib/src/standalone_ui/standalone_screen.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart b/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart index af4af1f1f8b..0072eed0310 100644 --- a/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart +++ b/packages/devtools_app/lib/src/standalone_ui/standalone_screen.dart @@ -8,8 +8,8 @@ import 'package:flutter/material.dart'; import '../shared/globals.dart'; import '../shared/ui/common_widgets.dart'; -import 'ide_shared/property_editor/property_editor_panel.dart'; import 'ide_shared/not_connected_overlay.dart'; +import 'ide_shared/property_editor/property_editor_panel.dart'; import 'vs_code/flutter_panel.dart'; /// "Screens" that are intended for standalone use only, likely for embedding