From ff601e946eb58ba815026f65045af87fa31635f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tam=C3=A1s=20G=C3=A1lffy?= Date: Fri, 14 Nov 2025 08:33:14 +0100 Subject: [PATCH 1/2] fix: Format minutes correctly --- addons/vest/plugin.cfg | 2 +- addons/vest/ui/vest-ui.gd | 2 +- tests/format-duration.test.gd | 16 ++++++++++++++++ 3 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 tests/format-duration.test.gd diff --git a/addons/vest/plugin.cfg b/addons/vest/plugin.cfg index f534949..37e7251 100644 --- a/addons/vest/plugin.cfg +++ b/addons/vest/plugin.cfg @@ -3,5 +3,5 @@ name="vest" description="A unit testing library for Godot" author="Tamás Gálffy and contributors" -version="1.10.3" +version="1.10.4" script="plugin.gd" diff --git a/addons/vest/ui/vest-ui.gd b/addons/vest/ui/vest-ui.gd index 60263a7..ff6e57f 100644 --- a/addons/vest/ui/vest-ui.gd +++ b/addons/vest/ui/vest-ui.gd @@ -204,7 +204,7 @@ static func get_status_icon(what: Variant) -> Texture2D: static func format_duration(duration: float) -> String: if duration > 60.: - return "%.2fmin" % duration + return "%.2fmin" % [duration / 60.] elif duration > 1.: return "%.2fs" % duration elif duration > 0.001: diff --git a/tests/format-duration.test.gd b/tests/format-duration.test.gd new file mode 100644 index 0000000..910847f --- /dev/null +++ b/tests/format-duration.test.gd @@ -0,0 +1,16 @@ +extends VestTest + +func get_suite_name(): + return "VestUI.format_duration()" + +func suite(): + var cases := [ + ["minutes", 150., "2.50min"], + ["seconds", 17.85, "17.85s"], + ["milliseconds", 0.758, "758.00ms"], + ["microseconds", 0.000_004_520, "4.52µs"], + ["rounding", 1.1705, "1.17s"] + ] + + for case in cases: + test(case[0], func(): expect_equal(VestUI.format_duration(case[1]), case[2])) From edca6f7a5d3905648d13c689552199114291ef24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tam=C3=A1s=20G=C3=A1lffy?= Date: Fri, 14 Nov 2025 08:36:45 +0100 Subject: [PATCH 2/2] uids --- tests/format-duration.test.gd.uid | 1 + 1 file changed, 1 insertion(+) create mode 100644 tests/format-duration.test.gd.uid diff --git a/tests/format-duration.test.gd.uid b/tests/format-duration.test.gd.uid new file mode 100644 index 0000000..a2cc3ab --- /dev/null +++ b/tests/format-duration.test.gd.uid @@ -0,0 +1 @@ +uid://d2mq852selen1