From 12f2c692434e887286d54a6ae4b13e2153aeb6ae Mon Sep 17 00:00:00 2001
From: Benjamin Johnson <42893476+bmjcode@users.noreply.github.com>
Date: Sun, 10 May 2026 13:08:00 -0400
Subject: [PATCH] Eliminate unused variables in PdfRenderer.draw()

This patch cleans up some cruft that was left over from an earlier
implementation. It also makes some small readability improvements and
fixes a documentation error where I mixed up the horizontal and vertical
scaling factors in the "actual size" calculation.
---
 qpageview/pdf.py | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/qpageview/pdf.py b/qpageview/pdf.py
index a765ea8..6bb15e4 100644
--- a/qpageview/pdf.py
+++ b/qpageview/pdf.py
@@ -247,8 +247,6 @@ def draw(self, page, painter, key, tile, paperColor=None):
 
         doc = page.document
         num = page.pageNumber
-        xres = painter.device().logicalDpiX()
-        yres = painter.device().logicalDpiY()
 
         # We use this to scale from key/tile to device coordinates
         matrix = painter.deviceTransform()
@@ -257,22 +255,20 @@ def draw(self, page, painter, key, tile, paperColor=None):
         # are "actual size" and scaling is our responsibility. When printing,
         # the painter coordinates are scaled to the device's resolution and
         # scaling is the device's responsibility.
-        vscale = matrix.m11()
-        hscale = matrix.m22()
-        actualSize = (vscale == hscale == 1)
+        # Note: m11 and m22 are our horizontal and vertical scaling factors.
+        actualSize = (matrix.m11() == matrix.m22() == 1)
 
         # Oversampling produces more readable output at lower resolutions
         # when painting at "actual size"
         if actualSize:
             # If our effective pixel density at this zoom level is below
             # our threshold, render at double size then downscale
-            xresEffective = 72.0 * key.width / pageSize.width()
-            yresEffective = 72.0 * key.height / pageSize.height()
-            xMultiplier = 2 if xresEffective < self.oversampleThreshold else 1
-            yMultiplier = 2 if yresEffective < self.oversampleThreshold else 1
+            xres = 72.0 * key.width / pageSize.width()
+            yres = 72.0 * key.height / pageSize.height()
+            xMultiplier = 2 if xres < self.oversampleThreshold else 1
+            yMultiplier = 2 if yres < self.oversampleThreshold else 1
         else:
-            xMultiplier = 1
-            yMultiplier = 1
+            xMultiplier = yMultiplier = 1
 
         # Set rendering options
         RenderFlag = QPdfDocumentRenderOptions.RenderFlag