-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
- Your templates have a lot of overlap, consider using a templating language like Jinja2 to construct your templates dynamically. This also would allow you to extract the Firebase configuration out of the templates and into your python server code, which can then be pulled from a environment variable or secrets file.
- I'm curious as to why you're passing in the nlp processor in various methods .py as opposed to simply importing it. Seems like an odd choice.
-
get_research_specdoesn't have a default return - Magic strings that can be reassigned to a variable
-
get_biodoesn't have a default return -
make_datatry except shouldn't be a naked except since it can hide other errors you might want to handle differently. Explicitly except the IndexError -
link_extraction.py getPublicationsshould be snake_case, and the repeated calls totargetText.replacecan be thrown into a loop.
Metadata
Metadata
Assignees
Labels
No labels