Use ToBeDeletedByClusterAutoscaler Taint to improve load balancing during machine terminations
#1054
+394
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a machine is deleted the it is possible that the load balancer do not know yet that the node is not available anymore. This results eventually in unsuccessful new connections as the node where the load balancer is forwarding the traffic is not existing anymore.
There are 2 ways a load balancer gets informed: 1. Via a reconcile of the load balancer in the
cloud-providerpackage or thekube-proxyhealth check. Unfortunately the "drain" or conditions set by the MCM dose not trigger a reconcile or the health check to fail.The
ToBeDeletedByClusterAutoscalerTaint is used in bothcloud-providerandkube-proxy, therefore we want to add this Taint to improve the load balancing during machine terminations.This is new step is added between
Initiate node drain/Delete Volume AttachmentsandInitiate VM deletionwith one additionalShortRetry(5s) to give thecloud-providerandkube-proxytime to react before removing the server.CC: @kon-angelo
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: