Lint dockerfile (#543)

* Update Alpine image version
* Consolidate RUN commands
* Pin package versions
* Add hadolint-action to lint Dockerfile on CI runs
* Fix wording

Author: mostafa

.github/workflows/test.yaml

@@ -66,16 +66,21 @@ jobs:
         with:
           go-version: "1.22"
 
-      - name: Lint code issues 🚨
+      - name: Lint code with golangci-lint 🚨
         uses: golangci/golangci-lint-action@v4
         with:
           version: "v1.57"
           skip-pkg-cache: true
           install-mode: "goinstall"
 
-      - name: Lint BASH script with shellcheck 🚨
+      - name: Lint Bash script with shellcheck 🚨
         uses: ludeeus/action-shellcheck@master
 
+      - name: Lint Dockerfile with hadolint 🚨
+        uses: hadolint/hadolint-action@v3.1.0
+        with:
+          dockerfile: Dockerfile
+
       - name: Run Go tests 🔬
         run: go test -p 1 -cover -covermode atomic -coverprofile=profile.cov -v ./...
         env:

Dockerfile

@@ -1,7 +1,7 @@
 # syntax=docker/dockerfile:1
 
 # Use the official golang image to build the binary.
-FROM golang:1.22-alpine3.19 as builder
+FROM golang:1.22-alpine3.20 as builder
 
 ARG TARGETOS
 ARG TARGETARCH
@@ -10,12 +10,12 @@ ARG TARGETPLATFORM
 WORKDIR /gatewayd
 COPY . /gatewayd
 
-RUN apk --no-cache add git make
-RUN mkdir -p dist
-RUN make build-platform GOOS=${TARGETOS} GOARCH=${TARGETARCH} OUTPUT_DIR=dist/${TARGETOS}-${TARGETARCH}
+RUN apk --no-cache add git=2.45.1-r0 make=4.4.1-r2 && \
+    mkdir -p dist && \
+    make build-platform GOOS=${TARGETOS} GOARCH=${TARGETARCH} OUTPUT_DIR=dist/${TARGETOS}-${TARGETARCH}
 
 # Use alpine to create a minimal image to run the gatewayd binary.
-FROM alpine:3.19 as runner
+FROM alpine:3.20 as runner
 
 ARG TARGETOS
 ARG TARGETARCH

docker-compose.yaml

@@ -2,7 +2,7 @@ services:
   install_plugins:
     # This intermediate service is used to install the plugins
     # before starting the GatewayD service.
-    image: alpine:3.18
+    image: alpine:3.20
     command: ["/bin/sh", "/setup.sh"]
     volumes:
       - ./setup.sh:/setup.sh:ro