return 0 when no fm record ID is given since no records are deleted

David Nahodyl · David Nahodyl · commit 1f43b01d903e · 2022-03-18T03:27:50.000-04:00
diff --git a/src/Database/Query/FMBaseBuilder.php b/src/Database/Query/FMBaseBuilder.php
@@ -236,6 +236,10 @@ public function delete($recordId = null)
     {
         $this->recordId($recordId ?? $this->getRecordId());
 
+        // return 0 if there's no record ID, as we can't delete anything
+        // deleting nothing is supported normally, but should return a 0
+        if ($this->getRecordId() === null) return 0;
+
         return $this->connection->deleteRecord($this);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,10 @@ public function delete($recordId = null)`
`236`	`236`	`{`
`237`	`237`	`$this->recordId($recordId ?? $this->getRecordId());`
`238`	`238`
	`239`	`+ // return 0 if there's no record ID, as we can't delete anything`
	`240`	`+ // deleting nothing is supported normally, but should return a 0`
	`241`	`+ if ($this->getRecordId() === null) return 0;`
	`242`	`+`
`239`	`243`	`return $this->connection->deleteRecord($this);`
`240`	`244`	`}`
`241`	`245`