moved the stripping of empty find requests to the FileMaker connection, right before we decide which endpoint to hit

Author: Smef

src/Database/Eloquent/FMEloquentBuilder.php

@@ -296,16 +296,6 @@ public function applyScopes()
     {
         $builder = parent::applyScopes();
 
-        $query = $builder->getQuery();
-
-        foreach ($query->wheres as $index => $find) {
-            if (! empty($find)) {
-                continue;
-            }
-
-            unset($query->wheres[$index]);
-        }
-
         return $builder;
     }
 

src/Services/FileMakerConnection.php

@@ -254,6 +254,12 @@ public function performFind(FMBaseBuilder $query)
             $query->limit = self::CRAZY_RECORDS_AMOUNT;
         }
 
+        // remove any empty arrays from wheres
+        // an empty find is invalid
+        $query->wheres = collect($query->wheres)->filter(function ($item) {
+            return is_array($item) ? count($item) > 0 : true;
+        })->toArray();
+
         // if there are no query parameters we need to do a get all records instead of a find
         if (empty($query->wheres) && ! $query->isForcingHighOffset()) {
             return $this->getRecords($query);
@@ -511,7 +517,7 @@ public function buildPostDataFromQuery(FMBaseBuilder $query)
         foreach ($params as $attribute => $request) {
             $value = $query->$attribute;
 
-            // just skip  everything else if the value is null
+            // just skip everything else if the value is null
             if ($value === null) {
                 continue;
             }