Fix network connection after soft-boot.#47
Open
garthk wants to merge 1 commit intogeekscape:masterfrom
Open
Conversation
When the LOLIN32 re-connected we got `sta_if.isconnected` and interpreted it as AP mode, in which we didn't set the global `connected`. In turn `is_connected()` stayed false, and `aiko.mqtt.mqtt_thread` would never try to connect, but `ping` would work. This change ensures `is_connected()` returns True if we wake with `network.WLAN(network.STA_IF).isconnected()` returning True. Tested with hard reset, `mpfshell --reset`, and soft reboot with `connection.net.wifi` either configured or left to its AP defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the LOLIN32 re-connected we got
sta_if.isconnectedand interpreted it as AP mode, in which we didn't set the globalconnected. In turnis_connected()stayed false, andaiko.mqtt.mqtt_threadwould never try to connect, butpingwould work.This change ensures
is_connected()returns True if we wake withnetwork.WLAN(network.STA_IF).isconnected()returning True.Tested with hard reset,
mpfshell --reset, and soft reboot withconnection.net.wifieither configured or left to its AP defaults.