Update convex to 1.31.0 (#880)

Author: Nicolapps

package-lock.json

@@ -27,7 +27,7 @@
   },
   "dependencies": {
     "classnames": "^2.3.2",
-    "convex": "^1.29.0",
+    "convex": "^1.31.0",
     "convex-helpers": "file:packages/convex-helpers/dist",
     "hono": "^4.3.6",
     "react": "^19.2.3",
@@ -53,7 +53,7 @@
     "@vitejs/plugin-react": "5.1.1",
     "@vitest/coverage-v8": "3.2.4",
     "chokidar-cli": "3.0.0",
-    "convex": "1.29.3",
+    "convex": "1.31.0",
     "convex-test": "0.0.39",
     "eslint": "9.39.1",
     "eslint-plugin-react": "7.37.5",

package.json

@@ -128,13 +128,11 @@ describe("row level security", () => {
       await expect(() =>
         asB.run(async (ctx) => {
           const rls = await withRLS(ctx);
-          // @ts-expect-error - testing new explicit table name API
           return rls.db.delete("notes", noteId);
         }),
       ).rejects.toThrow(/no read access/);
       await asA.run(async (ctx) => {
         const rls = await withRLS(ctx);
-        // @ts-expect-error - testing new explicit table name API
         return rls.db.delete("notes", noteId);
       });
     });
@@ -358,7 +356,6 @@ describe("row level security", () => {
         );
 
         // Should be able to modify (no modify rule, default allow)
-        // @ts-expect-error - testing new explicit table name API
         await db.patch("publicData", docId, { content: "Modified content" });
       });
 
@@ -381,7 +378,6 @@ describe("row level security", () => {
           );
 
           // Should NOT be able to modify (no modify rule, default deny)
-          // @ts-expect-error - testing new explicit table name API
           await db.patch("publicData", docId, {
             content: "Blocked modification",
           });

packages/convex-helpers/server/rowLevelSecurity.test.ts

@@ -369,8 +369,7 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
       arg2 !== undefined ? [arg0, arg1, arg2] : [null, arg0, arg1];
     await this.checkAuth(tableName, id);
     return tableName
-      ? // @ts-expect-error -- patch supports 3 args since convex@1.25.4
-        this.db.patch(tableName, id, value)
+      ? this.db.patch(tableName, id, value)
       : this.db.patch(id, value);
   }
 
@@ -388,8 +387,7 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
       arg2 !== undefined ? [arg0, arg1, arg2] : [null, arg0, arg1];
     await this.checkAuth(tableName, id);
     return tableName
-      ? // @ts-expect-error -- replace supports 3 args since convex@1.25.4
-        this.db.replace(tableName, id, value)
+      ? this.db.replace(tableName, id, value)
       : this.db.replace(id, value);
   }
 
@@ -403,10 +401,7 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
       arg1 !== undefined ? [arg0, arg1] : [null, arg0];
     await this.checkAuth(tableName, id);
 
-    return tableName
-      ? // @ts-expect-error -- delete supports 2 args since convex@1.25.4
-        this.db.delete(tableName, id)
-      : this.db.delete(id);
+    return tableName ? this.db.delete(tableName, id) : this.db.delete(id);
   }
 
   get<TableName extends TableNamesInDataModel<DataModel>>(
@@ -417,7 +412,6 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
     id: GenericId<TableName>,
   ): Promise<DocumentByName<DataModel, TableName> | null>;
   get(arg0: any, arg1?: any): Promise<any> {
-    // @ts-expect-error -- get supports 2 args since convex@1.25.4
     return this.reader.get(arg0, arg1);
   }
   query<TableName extends string>(tableName: TableName): QueryInitializer<any> {

packages/convex-helpers/server/rowLevelSecurity.ts

@@ -50,12 +50,7 @@ triggers.register("usersExplicit", async (ctx, change) => {
   if (change.newDoc) {
     const fullName = `${change.newDoc.firstName} ${change.newDoc.lastName}`;
     if (change.newDoc.fullName !== fullName) {
-      await ctx.db.patch(
-        "usersExplicit",
-        change.id,
-        // @ts-expect-error -- patch supports 3 args since convex@1.25.4, but the type is marked as internal
-        { fullName },
-      );
+      await ctx.db.patch("usersExplicit", change.id, { fullName });
     }
   }
 });
@@ -64,10 +59,12 @@ triggers.register("usersExplicitIncorrectTable", async (ctx, change) => {
     const fullName = `${change.newDoc.firstName} ${change.newDoc.lastName}`;
     if (change.newDoc.fullName !== fullName) {
       await ctx.db.patch(
+        // @ts-expect-error -- this code uses the wrong table name so it shouldn’t typecheck
         "users",
         change.id,
-        // @ts-expect-error -- patch supports 3 args since convex@1.25.4, but the type is marked as internal
-        { fullName },
+        {
+          fullName,
+        },
       );
     }
   }

packages/convex-helpers/server/triggers.test.ts

@@ -176,11 +176,7 @@ export class DatabaseWriterWithTriggers<
   ): Promise<void>;
   delete(id: GenericId<TableNamesInDataModel<DataModel>>): Promise<void>;
   delete(arg0: any, arg1?: any): Promise<void> {
-    return this.writer.delete(
-      arg0,
-      // @ts-expect-error -- delete supports 2 args since convex@1.25.4, but the type is marked as internal
-      arg1,
-    );
+    return this.writer.delete(arg0, arg1);
   }
 
   get<TableName extends TableNamesInDataModel<DataModel>>(
@@ -191,11 +187,7 @@ export class DatabaseWriterWithTriggers<
     id: GenericId<TableName>,
   ): Promise<DocumentByName<DataModel, TableName> | null>;
   get(arg0: any, arg1?: any) {
-    return this.writer.get(
-      arg0,
-      // @ts-expect-error -- get supports 2 args since convex@1.25.4, but the type is marked as internal
-      arg1,
-    );
+    return this.writer.get(arg0, arg1);
   }
 
   insert<TableName extends TableNamesInDataModel<DataModel>>(
@@ -215,12 +207,7 @@ export class DatabaseWriterWithTriggers<
     value: PatchValue<DocumentByName<DataModel, TableName>>,
   ): Promise<void>;
   patch(arg0: any, arg1: any, arg2?: any): Promise<void> {
-    return this.writer.patch(
-      arg0,
-      arg1,
-      // @ts-expect-error -- patch supports 3 args since convex@1.25.4, but the type is marked as internal
-      arg2,
-    );
+    return this.writer.patch(arg0, arg1, arg2);
   }
 
   query<TableName extends TableNamesInDataModel<DataModel>>(
@@ -246,12 +233,7 @@ export class DatabaseWriterWithTriggers<
     value: WithOptionalSystemFields<DocumentByName<DataModel, TableName>>,
   ): Promise<void>;
   replace(arg0: any, arg1: any, arg2?: any): Promise<void> {
-    return this.writer.replace(
-      arg0,
-      arg1,
-      // @ts-expect-error -- replace supports 3 args since convex@1.25.4, but the type is marked as internal
-      arg2,
-    );
+    return this.writer.replace(arg0, arg1, arg2);
   }
 
   system: GenericDatabaseWriter<DataModel>["system"];
@@ -302,12 +284,7 @@ export function writerWithTriggers<
       isWithinTrigger,
       async () => {
         const oldDoc = (await innerDb.get(id))!;
-        await innerDb.patch(
-          tableName,
-          id,
-          // @ts-expect-error -- patch supports 3 args since convex@1.25.4, but the type is marked as internal
-          value,
-        );
+        await innerDb.patch(tableName, id, value);
         const newDoc = (await innerDb.get(id))!;
         return [undefined, { operation: "update", id, oldDoc, newDoc }];
       },
@@ -348,12 +325,7 @@ export function writerWithTriggers<
       isWithinTrigger,
       async () => {
         const oldDoc = (await innerDb.get(id))!;
-        await innerDb.replace(
-          tableName,
-          id,
-          // @ts-expect-error -- replace supports 3 args since convex@1.25.4, but the type is marked as internal
-          value,
-        );
+        await innerDb.replace(tableName, id, value);
         const newDoc = (await innerDb.get(id))!;
         return [undefined, { operation: "update", id, oldDoc, newDoc }];
       },
@@ -389,11 +361,7 @@ export function writerWithTriggers<
       isWithinTrigger,
       async () => {
         const oldDoc = (await innerDb.get(id))!;
-        await innerDb.delete(
-          tableName,
-          // @ts-expect-error -- delete supports 2 args since convex@1.25.4, but the type is marked as internal
-          id,
-        );
+        await innerDb.delete(tableName, id);
         return [undefined, { operation: "delete", id, oldDoc, newDoc: null }];
       },
     );