test something

Author: s1gr1d

packages/node/src/integrations/tracing/redis.ts

@@ -33,7 +33,10 @@ export const instrumentRedis = generateInstrumentOnce(INTEGRATION_NAME, () => {
 
       span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.redis');
 
+      const cacheOperation = getCacheOperation(redisCommand);
+
       if (
+        !cacheOperation ||
         !_redisOptions?.cachePrefixes ||
         !shouldConsiderForCache(redisCommand, safeKey, _redisOptions.cachePrefixes)
       ) {
@@ -49,14 +52,11 @@ export const instrumentRedis = generateInstrumentOnce(INTEGRATION_NAME, () => {
         span.setAttributes({ 'network.peer.address': networkPeerAddress, 'network.peer.port': networkPeerPort });
       }
 
-      const cacheOperation = getCacheOperation(redisCommand);
-
-      if (!cacheOperation) {
-        // redis command unsupported as cache operation
-        return;
-      }
-
+      // eslint-disable-next-line no-console
+      console.log('response', response);
       const cacheItemSize = calculateCacheItemSize(response);
+      // eslint-disable-next-line no-console
+      console.log('cacheItemSize', cacheItemSize);
       if (cacheItemSize) {
         span.setAttribute(SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE, cacheItemSize);
       }
@@ -71,6 +71,8 @@ export const instrumentRedis = generateInstrumentOnce(INTEGRATION_NAME, () => {
       });
 
       span.updateName(safeKey.length > 1024 ? `${safeKey.substring(0, 1024)}...` : safeKey);
+      // eslint-disable-next-line no-console
+      console.log('span',span);
     },
   });
 });

packages/node/src/utils/redisCache.ts

@@ -8,9 +8,9 @@ export const SET_COMMANDS = ['set' /* todo: 'setex' */];
 
 /** Determine cache operation based on redis statement */
 export function getCacheOperation(
-  statement: string,
+  command: string,
 ): 'cache.get' | 'cache.put' | 'cache.remove' | 'cache.flush' | undefined {
-  const lowercaseStatement = statement.toLowerCase();
+  const lowercaseStatement = command.toLowerCase();
 
   if (GET_COMMANDS.includes(lowercaseStatement)) {
     return 'cache.get';

packages/opentelemetry/src/utils/parseSpanDescription.ts

@@ -52,7 +52,7 @@ export function parseSpanDescription(span: AbstractSpan): SpanDescription {
   // If db.type exists then this is a database call span
   // If the Redis DB is used as a cache, the span description should not be changed
   if (dbSystem && (!attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP] || !opIsCache)) {
-    return descriptionForDbSystem({ attributes, name });
+    // return descriptionForDbSystem({ attributes, name });
   }
 
   // If rpc.service exists then this is a rpc call span.