Commit 847daf0
authored
feat(profiling): Add support for Node v24 in the prune script (#18447)
(closes #18428)
(closes
[JS-1266](https://linear.app/getsentry/issue/JS-1266/sentry-prune-profiler-binaries-does-not-recognize-nodejs-24-as-a-valid))
This adds support for Node v24 in the prune script.
On top this also adds a test that is testing against the current Node
version (as suggested in
#14491 (review)).
Since we have [a
matrix](https://github.com/getsentry/sentry-javascript/blob/a906759fd8769d264498598dc16dab8af26377ea/.github/workflows/build.yml#L747)
for our integration tests, this test would fail once we add Node v26 -
where we are forced to update the ABI manually.
Theoretically we could also use
[node-abi](https://www.npmjs.com/package/node-abi), but decided against
it to keep the dependencies low.1 parent 5c5c7d4 commit 847daf0
File tree
2 files changed
+27
-0
lines changed- packages/profiling-node
- scripts
- test
2 files changed
+27
-0
lines changedLines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| 80 | + | |
| 81 | + | |
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
| |||
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
0 commit comments